Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: content/renderer/scheduler/task_queue_manager.cc

Issue 737353003: Fix WeakPtrFactory member ordering in content (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolved typo Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/scheduler/task_queue_manager.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/scheduler/task_queue_manager.h" 5 #include "content/renderer/scheduler/task_queue_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/trace_event.h" 8 #include "base/debug/trace_event.h"
9 #include "base/debug/trace_event_argument.h" 9 #include "base/debug/trace_event_argument.h"
10 #include "content/renderer/scheduler/task_queue_selector.h" 10 #include "content/renderer/scheduler/task_queue_selector.h"
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 } 240 }
241 241
242 } // namespace internal 242 } // namespace internal
243 243
244 TaskQueueManager::TaskQueueManager( 244 TaskQueueManager::TaskQueueManager(
245 size_t task_queue_count, 245 size_t task_queue_count,
246 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner, 246 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner,
247 TaskQueueSelector* selector) 247 TaskQueueSelector* selector)
248 : main_task_runner_(main_task_runner), 248 : main_task_runner_(main_task_runner),
249 selector_(selector), 249 selector_(selector),
250 weak_factory_(this), 250 pending_dowork_count_(0),
251 pending_dowork_count_(0) { 251 weak_factory_(this) {
252 DCHECK(main_task_runner->RunsTasksOnCurrentThread()); 252 DCHECK(main_task_runner->RunsTasksOnCurrentThread());
253 TRACE_EVENT_OBJECT_CREATED_WITH_ID( 253 TRACE_EVENT_OBJECT_CREATED_WITH_ID(
254 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "TaskQueueManager", 254 TRACE_DISABLED_BY_DEFAULT("renderer.scheduler"), "TaskQueueManager",
255 this); 255 this);
256 256
257 task_queue_manager_weak_ptr_ = weak_factory_.GetWeakPtr(); 257 task_queue_manager_weak_ptr_ = weak_factory_.GetWeakPtr();
258 for (size_t i = 0; i < task_queue_count; i++) { 258 for (size_t i = 0; i < task_queue_count; i++) {
259 scoped_refptr<internal::TaskQueue> queue( 259 scoped_refptr<internal::TaskQueue> queue(
260 make_scoped_refptr(new internal::TaskQueue(this))); 260 make_scoped_refptr(new internal::TaskQueue(this)));
261 queues_.push_back(queue); 261 queues_.push_back(queue);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 state->EndArray(); 404 state->EndArray();
405 state->BeginDictionary("selector"); 405 state->BeginDictionary("selector");
406 selector_->AsValueInto(state.get()); 406 selector_->AsValueInto(state.get());
407 state->EndDictionary(); 407 state->EndDictionary();
408 if (should_run) 408 if (should_run)
409 state->SetInteger("selected_queue", selected_queue); 409 state->SetInteger("selected_queue", selected_queue);
410 return state; 410 return state;
411 } 411 }
412 412
413 } // namespace content 413 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/scheduler/task_queue_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698