Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 735823004: Make ProtoDatabase properly handle failed Init (Closed)

Created:
6 years, 1 month ago by cjhopman
Modified:
6 years, 1 month ago
Reviewers:
Mathieu
CC:
chromium-reviews, pavely
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make ProtoDatabase properly handle failed Init When Init fails, further Save/Load calls should just fail (and not crash). This makes the underlying LevelDB properly handle the Init failed case and adds tests for that. Adds LevelDB::InitWithOptions to make it easy to have the Init fail in tests. Committed: https://crrev.com/1aad174b259bc655e7b9e973fadfc79bc5c00e51 Cr-Commit-Position: refs/heads/master@{#304944}

Patch Set 1 #

Patch Set 2 : git cl format #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -6 lines) Patch
M components/leveldb_proto/leveldb_database.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/leveldb_proto/leveldb_database.cc View 1 2 3 chunks +18 lines, -6 lines 0 comments Download
M components/leveldb_proto/proto_database_impl_unittest.cc View 1 2 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
cjhopman
mathp: *
6 years, 1 month ago (2014-11-19 00:11:37 UTC) #2
Mathieu
Thanks for the fix, lgtm.
6 years, 1 month ago (2014-11-19 16:11:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735823004/20001
6 years, 1 month ago (2014-11-19 22:24:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/29928)
6 years, 1 month ago (2014-11-19 23:22:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735823004/20001
6 years, 1 month ago (2014-11-19 23:34:33 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/735823004/40001
6 years, 1 month ago (2014-11-19 23:46:41 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-20 00:30:16 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 00:31:09 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1aad174b259bc655e7b9e973fadfc79bc5c00e51
Cr-Commit-Position: refs/heads/master@{#304944}

Powered by Google App Engine
This is Rietveld 408576698