sky/engine/core/dom/Position.cpp - Issue 735193002: Remove lots of things from RenderObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/dom/Position.cpp

Issue 735193002: Remove lots of things from RenderObject (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/dom/Position.cpp

diff --git a/sky/engine/core/dom/Position.cpp b/sky/engine/core/dom/Position.cpp

index e4fc0b85eb13d134a1f1d1744ad4f4c5f34870c1..ed3c943dbdd635608ceec3380275ba8d7810d3fa 100644

--- a/sky/engine/core/dom/Position.cpp

+++ b/sky/engine/core/dom/Position.cpp

@@ -748,7 +748,7 @@ bool Position::hasRenderedNonAnonymousDescendantsWithHeight(RenderObject* render

{

RenderObject* stop = renderer->nextInPreOrderAfterChildren();

for (RenderObject *o = renderer->slowFirstChild(); o && o != stop; o = o->nextInPreOrder())

- if (o->nonPseudoNode()) {

+ if (o->node()) {

if ((o->isText() && toRenderText(o)->linesBoundingBox().height())

|| (o->isBox() && toRenderBox(o)->pixelSnappedLogicalHeight())

|| (o->isRenderInline() && isEmptyInline(o) && toRenderInline(o)->linesBoundingBox().height()))

« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/editing/TextIterator.cpp » ('j') | no next file with comments »