Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Side by Side Diff: sky/engine/core/dom/Position.cpp

Issue 735193002: Remove lots of things from RenderObject (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/editing/TextIterator.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
741 } 741 }
742 } 742 }
743 743
744 return lastVisible; 744 return lastVisible;
745 } 745 }
746 746
747 bool Position::hasRenderedNonAnonymousDescendantsWithHeight(RenderObject* render er) 747 bool Position::hasRenderedNonAnonymousDescendantsWithHeight(RenderObject* render er)
748 { 748 {
749 RenderObject* stop = renderer->nextInPreOrderAfterChildren(); 749 RenderObject* stop = renderer->nextInPreOrderAfterChildren();
750 for (RenderObject *o = renderer->slowFirstChild(); o && o != stop; o = o->ne xtInPreOrder()) 750 for (RenderObject *o = renderer->slowFirstChild(); o && o != stop; o = o->ne xtInPreOrder())
751 if (o->nonPseudoNode()) { 751 if (o->node()) {
752 if ((o->isText() && toRenderText(o)->linesBoundingBox().height()) 752 if ((o->isText() && toRenderText(o)->linesBoundingBox().height())
753 || (o->isBox() && toRenderBox(o)->pixelSnappedLogicalHeight()) 753 || (o->isBox() && toRenderBox(o)->pixelSnappedLogicalHeight())
754 || (o->isRenderInline() && isEmptyInline(o) && toRenderInline(o) ->linesBoundingBox().height())) 754 || (o->isRenderInline() && isEmptyInline(o) && toRenderInline(o) ->linesBoundingBox().height()))
755 return true; 755 return true;
756 } 756 }
757 return false; 757 return false;
758 } 758 }
759 759
760 bool Position::nodeIsUserSelectNone(Node* node) 760 bool Position::nodeIsUserSelectNone(Node* node)
761 { 761 {
(...skipping 473 matching lines...) Expand 10 before | Expand all | Expand 10 after
1235 pos.showTreeForThis(); 1235 pos.showTreeForThis();
1236 } 1236 }
1237 1237
1238 void showTree(const blink::Position* pos) 1238 void showTree(const blink::Position* pos)
1239 { 1239 {
1240 if (pos) 1240 if (pos)
1241 pos->showTreeForThis(); 1241 pos->showTreeForThis();
1242 } 1242 }
1243 1243
1244 #endif 1244 #endif
OLDNEW
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/editing/TextIterator.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698