sky/engine/core/editing/TextIterator.cpp - Issue 735193002: Remove lots of things from RenderObject

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/TextIterator.cpp

Issue 735193002: Remove lots of things from RenderObject (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/editing/TextIterator.cpp

diff --git a/sky/engine/core/editing/TextIterator.cpp b/sky/engine/core/editing/TextIterator.cpp

index 19f9e42dd2120a6309d90fa5a37fb37917e466e9..eebe2604820237589dc9ae483585998ad02fa6af 100644

--- a/sky/engine/core/editing/TextIterator.cpp

+++ b/sky/engine/core/editing/TextIterator.cpp

@@ -419,7 +419,7 @@ void TextIterator::advance()

bool handledNode = false;

if (renderer->isText() && m_node->nodeType() == Node::TEXT_NODE) {

handledNode = handleTextNode();

- } else if (renderer && (renderer->isImage() || renderer->isWidget())) {

+ } else if (renderer && renderer->isImage()) {

handledNode = handleReplacedElement();

} else {

handledNode = handleNonTextNode();

@@ -1038,7 +1038,7 @@ void SimplifiedBackwardsTextIterator::advance()

if (renderer && renderer->isText() && m_node->nodeType() == Node::TEXT_NODE) {

if (m_offset > 0)

m_handledNode = handleTextNode();

- } else if (renderer && (renderer->isImage() || renderer->isWidget())) {

+ } else if (renderer && renderer->isImage()) {

if (m_offset > 0)

m_handledNode = handleReplacedElement();

} else {

« no previous file with comments | « sky/engine/core/dom/Position.cpp ('k') | sky/engine/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »