Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx (Closed)

Created:
6 years, 1 month ago by Sunil Ratnu
Modified:
6 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Do not save passwords if the landing page has HTTP status 5xx or 4xx If the server throws internal error, access denied, page not found etc. after a login attempt, there is no reason to believe that the user put in credentials they would like to save. So we should not suggest saving in that case. BUG=432592 Committed: https://crrev.com/a3d924feb1bd3e3e2dab6ba85786db63334e8312 Cr-Commit-Position: refs/heads/master@{#304783}

Patch Set 1 : #

Total comments: 8

Patch Set 2 : Addressing Vaclav's review comments #

Total comments: 9

Patch Set 3 : Correction in the browser test #

Patch Set 4 : Rebase #

Total comments: 2

Messages

Total messages: 26 (9 generated)
Sunil Ratnu
Hi Vaclav, Please have a look. Thanks! Sunil
6 years, 1 month ago (2014-11-17 03:28:30 UTC) #3
vabr (Chromium)
Thanks, Sunil Ratnu. So far this looks good (do read the comments, though). But please ...
6 years, 1 month ago (2014-11-17 15:32:15 UTC) #4
Sunil Ratnu
Hi Vaclav, Thanks for the review. I've made the suggested changes and also written the ...
6 years, 1 month ago (2014-11-18 06:40:06 UTC) #6
vabr (Chromium)
Hi Sunil, Thanks for the new patch set, I added some comments. As for the ...
6 years, 1 month ago (2014-11-18 10:10:11 UTC) #7
Sunil Ratnu
Hi Vaclav, Thank you for the review and valuable suggestions. The test works fine now. ...
6 years, 1 month ago (2014-11-18 12:58:39 UTC) #8
vabr (Chromium)
LGTM, thanks! https://codereview.chromium.org/733953002/diff/60001/chrome/browser/password_manager/chrome_password_manager_client.cc File chrome/browser/password_manager/chrome_password_manager_client.cc (right): https://codereview.chromium.org/733953002/diff/60001/chrome/browser/password_manager/chrome_password_manager_client.cc#newcode303 chrome/browser/password_manager/chrome_password_manager_client.cc:303: ChromePasswordManagerClient* client = On 2014/11/18 12:58:39, Sunil ...
6 years, 1 month ago (2014-11-18 14:22:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733953002/80001
6 years, 1 month ago (2014-11-18 14:46:57 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6585)
6 years, 1 month ago (2014-11-18 15:26:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733953002/80001
6 years, 1 month ago (2014-11-18 15:38:41 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/482)
6 years, 1 month ago (2014-11-18 16:37:05 UTC) #17
vabr (Chromium)
Sunil Ratnu, It looks like PromptAfterSubmitWithSubFrameNavigation is broken now -- I guess it navigates to ...
6 years, 1 month ago (2014-11-18 16:44:31 UTC) #18
Sunil Ratnu
On 2014/11/18 16:44:31, vabr (Chromium) wrote: > Sunil Ratnu, > > It looks like PromptAfterSubmitWithSubFrameNavigation ...
6 years, 1 month ago (2014-11-19 07:22:26 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/733953002/120001
6 years, 1 month ago (2014-11-19 07:24:55 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:120001)
6 years, 1 month ago (2014-11-19 08:23:44 UTC) #23
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a3d924feb1bd3e3e2dab6ba85786db63334e8312 Cr-Commit-Position: refs/heads/master@{#304783}
6 years, 1 month ago (2014-11-19 08:24:24 UTC) #24
vabr (Chromium)
Thank you, Sunil Ratnu. The landed patch set LGTM. I have one post-landing commit, though. ...
6 years, 1 month ago (2014-11-19 10:04:02 UTC) #25
Sunil Ratnu
6 years, 1 month ago (2014-11-19 11:20:50 UTC) #26
Message was sent while issue was closed.
https://codereview.chromium.org/733953002/diff/120001/chrome/test/data/passwo...
File chrome/test/data/password/other.html (right):

https://codereview.chromium.org/733953002/diff/120001/chrome/test/data/passwo...
chrome/test/data/password/other.html:3: Navigation complete.
On 2014/11/19 10:04:02, vabr (Chromium) wrote:
> Could you please add a not in this file, saying something like:
> "Do not merge this file with done.html, the test
> PromptAfterSubmitWithSubFrameNavigation needs two such files, with different
> filenames."

Thanks for that point Vaclav. Made the changes in
https://codereview.chromium.org/726703006/ .

Powered by Google App Engine
This is Rietveld 408576698