chrome/test/data/password/other.html - Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/password/other.html

Issue 733953002: Do not save passwords if the landing page has HTTP status 5xx or 4xx (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <body>

	3 Navigation complete.
	vabr (Chromium) 2014/11/19 10:04:02 Could you please add a not in this file, saying so Could you please add a not in this file, saying something like: "Do not merge this file with done.html, the test PromptAfterSubmitWithSubFrameNavigation needs two such files, with different filenames." Sunil Ratnu 2014/11/19 11:20:50 Thanks for that point Vaclav. Made the changes in Show quoted text On 2014/11/19 10:04:02, vabr (Chromium) wrote: > Could you please add a not in this file, saying something like: > "Do not merge this file with done.html, the test > PromptAfterSubmitWithSubFrameNavigation needs two such files, with different > filenames." Thanks for that point Vaclav. Made the changes in https://codereview.chromium.org/726703006/ .
	4 </body>

	5 </html>

OLD	NEW

« no previous file with comments | « chrome/browser/password_manager/password_manager_browsertest.cc ('k') | chrome/test/data/password/password_form.html » ('j') | no next file with comments »