Do not save passwords if the landing page has HTTP status 5xx or 4xx

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 272 matching lines @@
   if (service)
     service->ProcessLog(text);
 }
 
 bool ChromePasswordManagerClient::IsLoggingActive() const {
   // WebUI tabs do not need to log password saving progress. In particular, the
   // internals page itself should not send any logs.
   return can_use_log_router_ && !web_contents()->GetWebUI();
 }
 
+bool ChromePasswordManagerClient::WasLastNavigationHTTPError() const {
+  DCHECK(web_contents());

[vabr (Chromium), 2014/11/17 15:32:15]

Please create here an instance of BrowserSavePasswordProgressLogger and log:
(1) the name of this method (via LogMessage)
(2) the HTTP status code number (if obtained, via LogNumber)

Only create the browser if IsLoggingActive() is true, and add new string IDs for
both new messages. Feel free to get inspiration from logging in, e.g.,
PasswordManager::ProvisionallySavePassword.

[Sunil Ratnu, 2014/11/18 06:40:05]

Done.

+  content::NavigationEntry* entry =
+      web_contents()->GetController().GetVisibleEntry();
+  if (!entry)
+    return false;
+  int http_status_code = entry->GetHttpStatusCode();
+  if (http_status_code >= 400 && http_status_code <= 600)

[vabr (Chromium), 2014/11/17 15:32:15]

Please change "<= 600" to "< 600".
There does not seem to be a HTTP 600 status code, but if somebody later
introduces the 6xx family of codes, the code should not make false assumptions
about it.

[Sunil Ratnu, 2014/11/18 06:40:05]

Done.

+    return true;
+  return false;
+}
+
 // static
 password_manager::PasswordGenerationManager*
 ChromePasswordManagerClient::GetGenerationManagerFromWebContents(
     content::WebContents* contents) {
   ChromePasswordManagerClient* client =
       ChromePasswordManagerClient::FromWebContents(contents);
   if (!client)
     return NULL;
   return client->GetDriver()->GetPasswordGenerationManager();
 }
@@ skipping 186 matching lines @@
 
   if (group_name == "DisallowSyncCredentialsForReauth") {
     autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS_FOR_REAUTH;
   } else if (group_name == "DisallowSyncCredentials") {
       autofill_sync_state_ = DISALLOW_SYNC_CREDENTIALS;
   } else {
     // Allow by default.
     autofill_sync_state_ = ALLOW_SYNC_CREDENTIALS;
   }
 }