telemetry: Fix page_cycler.netsim.top_10.

telemetry: Fix page_cycler.netsim.top_10.

Fix the broken page_cycler.netsim.top_10 and remove the rather ugly
clear_cache_before_ache_run class member. The fixed version should
not have the issue of affecting subsequent page_cycler runs.

R=tonyg@chromium.org
BUG=434927
Committed: https://crrev.com/b576b5b8ed08e8edc4b9637aca2f2ab819ee4843
Cr-Commit-Position: refs/heads/master@{#304966}

[ernstm, 2014-11-20 01:19:17]

PTAL

[tonyg, 2014-11-20 01:22:48]

https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/shared_page_state.py (left):

https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:212:
self._current_tab.ClearCache(force=True)
How does this work now?

[ernstm, 2014-11-20 01:26:44]

https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/shared_page_state.py (left):

https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:212:
self._current_tab.ClearCache(force=True)
On 2014/11/20 01:22:48, tonyg wrote:
> How does this work now?

The page_cycler benchmark was setting the class member
clear_cache_before_each_run on the page_cycler measurement, which makes  the
condition True. I think it's pretty ugly and I don't see it being used anywhere
else -> remove.

[ernstm, 2014-11-20 01:34:51]

https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
File tools/telemetry/telemetry/page/shared_page_state.py (left):

https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
tools/telemetry/telemetry/page/shared_page_state.py:212:
self._current_tab.ClearCache(force=True)
On 2014/11/20 01:26:43, ernstm wrote:
> On 2014/11/20 01:22:48, tonyg wrote:
> > How does this work now?
> 
> The page_cycler benchmark was setting the class member
> clear_cache_before_each_run on the page_cycler measurement, which makes  the
> condition True. I think it's pretty ugly and I don't see it being used
anywhere
> else -> remove.

I put the cache clearing logic back.

[tonyg, 2014-11-20 01:35:13]

The CQ bit was checked by tonyg@chromium.org

[tonyg, 2014-11-20 01:35:13]

lgtm

[dtu, 2014-11-20 01:35:45]

On 2014/11/20 01:26:44, ernstm wrote:
>
https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
> File tools/telemetry/telemetry/page/shared_page_state.py (left):
> 
>
https://codereview.chromium.org/733463005/diff/1/tools/telemetry/telemetry/pa...
> tools/telemetry/telemetry/page/shared_page_state.py:212:
> self._current_tab.ClearCache(force=True)
> On 2014/11/20 01:22:48, tonyg wrote:
> > How does this work now?
> 
> The page_cycler benchmark was setting the class member
> clear_cache_before_each_run on the page_cycler measurement, which makes  the
> condition True. I think it's pretty ugly and I don't see it being used
anywhere
> else -> remove.

Thank goodness, I remember this hack. Sooo lgtm

[ernstm, 2014-11-20 01:35:46]

The CQ bit was checked by ernstm@chromium.org

[commit-bot: I haz the power, 2014-11-20 01:36:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/733463005/20001

[ernstm, 2014-11-20 01:37:16]

> > The page_cycler benchmark was setting the class member
> > clear_cache_before_each_run on the page_cycler measurement, which makes  the
> > condition True. I think it's pretty ugly and I don't see it being used
> anywhere
> > else -> remove.
> 
> Thank goodness, I remember this hack. Sooo lgtm

Turns out that we still need the cache clearing logic here, but the flag now
comes through the constructor of PageTest, not the class member hack.

[commit-bot: I haz the power, 2014-11-20 03:56:48]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-20 03:57:38]

Patchset 2 (id:??) landed as
https://crrev.com/b576b5b8ed08e8edc4b9637aca2f2ab819ee4843
Cr-Commit-Position: refs/heads/master@{#304966}