Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: tools/perf/benchmarks/page_cycler.py

Issue 733463005: telemetry: Fix page_cycler.netsim.top_10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put cache clearing logic back into SharedPageState. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/page_cycler.py
diff --git a/tools/perf/benchmarks/page_cycler.py b/tools/perf/benchmarks/page_cycler.py
index c10b811ed87c78e2f434d278b8dbb8bddfe84f26..cdb0fdf680201953a9231671713730a0b4a30828 100644
--- a/tools/perf/benchmarks/page_cycler.py
+++ b/tools/perf/benchmarks/page_cycler.py
@@ -77,11 +77,14 @@ class PageCyclerNetsimTop10(_PageCycler):
'pageset_repeat': 5,
}
- def __init__(self):
- super(PageCyclerNetsimTop10, self).__init__()
- # TODO: This isn't quite right.
- # This option will still apply to page cyclers that run after this one.
- self.test.clear_cache_before_each_run = True
+ def CreatePageTest(self, options):
+ return page_cycler.PageCycler(
+ page_repeat = options.page_repeat,
+ pageset_repeat = options.pageset_repeat,
+ cold_load_percent = options.cold_load_percent,
+ record_v8_object_stats = options.v8_object_stats,
+ report_speed_index = options.report_speed_index,
+ clear_cache_before_each_run = True)
@benchmark.Enabled('android')
« no previous file with comments | « no previous file | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698