Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: tools/perf/benchmarks/page_cycler.py

Issue 733463005: telemetry: Fix page_cycler.netsim.top_10. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Put cache clearing logic back into SharedPageState. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from measurements import page_cycler 5 from measurements import page_cycler
6 import page_sets 6 import page_sets
7 from telemetry import benchmark 7 from telemetry import benchmark
8 8
9 9
10 class _PageCycler(benchmark.Benchmark): 10 class _PageCycler(benchmark.Benchmark):
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 class PageCyclerNetsimTop10(_PageCycler): 70 class PageCyclerNetsimTop10(_PageCycler):
71 """Measures load time of the top 10 sites under simulated cable network.""" 71 """Measures load time of the top 10 sites under simulated cable network."""
72 tag = 'netsim' 72 tag = 'netsim'
73 page_set = page_sets.Top10PageSet 73 page_set = page_sets.Top10PageSet
74 options = { 74 options = {
75 'cold_load_percent': 100, 75 'cold_load_percent': 100,
76 'extra_wpr_args_as_string': '--shaping_type=proxy --net=cable', 76 'extra_wpr_args_as_string': '--shaping_type=proxy --net=cable',
77 'pageset_repeat': 5, 77 'pageset_repeat': 5,
78 } 78 }
79 79
80 def __init__(self): 80 def CreatePageTest(self, options):
81 super(PageCyclerNetsimTop10, self).__init__() 81 return page_cycler.PageCycler(
82 # TODO: This isn't quite right. 82 page_repeat = options.page_repeat,
83 # This option will still apply to page cyclers that run after this one. 83 pageset_repeat = options.pageset_repeat,
84 self.test.clear_cache_before_each_run = True 84 cold_load_percent = options.cold_load_percent,
85 record_v8_object_stats = options.v8_object_stats,
86 report_speed_index = options.report_speed_index,
87 clear_cache_before_each_run = True)
85 88
86 89
87 @benchmark.Enabled('android') 90 @benchmark.Enabled('android')
88 class PageCyclerTop10Mobile(_PageCycler): 91 class PageCyclerTop10Mobile(_PageCycler):
89 page_set = page_sets.Top10MobilePageSet 92 page_set = page_sets.Top10MobilePageSet
90 93
91 94
92 @benchmark.Disabled 95 @benchmark.Disabled
93 class PageCyclerKeyMobileSites(_PageCycler): 96 class PageCyclerKeyMobileSites(_PageCycler):
94 page_set = page_sets.KeyMobileSitesPageSet 97 page_set = page_sets.KeyMobileSitesPageSet
95 98
96 99
97 @benchmark.Disabled('android') # crbug.com/357326 100 @benchmark.Disabled('android') # crbug.com/357326
98 class PageCyclerToughLayoutCases(_PageCycler): 101 class PageCyclerToughLayoutCases(_PageCycler):
99 page_set = page_sets.ToughLayoutCasesPageSet 102 page_set = page_sets.ToughLayoutCasesPageSet
100 103
101 104
102 # crbug.com/273986: This test is really flakey on xp. 105 # crbug.com/273986: This test is really flakey on xp.
103 # cabug.com/341843: This test is always timing out on Android. 106 # cabug.com/341843: This test is always timing out on Android.
104 @benchmark.Disabled('android', 'win') 107 @benchmark.Disabled('android', 'win')
105 class PageCyclerTypical25(_PageCycler): 108 class PageCyclerTypical25(_PageCycler):
106 page_set = page_sets.Typical25PageSet 109 page_set = page_sets.Typical25PageSet
OLDNEW
« no previous file with comments | « no previous file | tools/perf/measurements/page_cycler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698