Introduce isWindowsVistaOrGreater() as replacement of windowsVersion()

Introduce isWindowsVistaOrGreater() as replacement of windowsVersion()

This patch is a part of preparation of migrating Win SDK 8.1.

This patch introduces isWindowsVistaOrGreater() as replacement of windowsVersion() to avoid using deprecated Windows API GetVersionEx(), which is deprecated since Win SDK 8.1+, by using new Windows API IsWindowsVistaOrGreater() for Win SDK 8.1 build or VerifyVersionInfo() before Win SDK 8.1.

BUG=n/a
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160698

[yosin_UTC9, 2013-10-24 09:52:47]

Could you review this patch?
Thanks in advance.

[Hajime Morrita, 2013-10-24 10:29:38]

rubberstamp LGTM for make it work.
yukawa@ might know what's the best way to handle this.

[yukawa, 2013-10-24 11:35:38]

lgtm

https://codereview.chromium.org/39693002/diff/1/Source/platform/win/SystemInf...
File Source/platform/win/SystemInfo.cpp (left):

https://codereview.chromium.org/39693002/diff/1/Source/platform/win/SystemInf...
Source/platform/win/SystemInfo.cpp:44:
GetVersionEx(reinterpret_cast<OSVERSIONINFO*>(&versionInfo));
Just FYI, you can also suppress warning only in one line as follows.  It's up to
you guys though.
#pragma warning(suppress:4996)  // deprecated in Win 8.1+
        GetVersionEx(reinterpret_cast<OSVERSIONINFO*>(&versionInfo));

[commit-bot: I haz the power, 2013-10-25 03:29:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/39693002/120001

[commit-bot: I haz the power, 2013-10-25 04:02:28]

Retried try job too often on blink_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=blink_pres...

[yosin_UTC9, 2013-10-25 04:23:24]

+tkent as owner of Source/Platform

Could you review this patch?
Thanks in advance.

[tkent, 2013-10-25 04:42:46]

The usage scenario of windowsVersion() is just "XP or not".
How about replacing windowsVersion() with new isWindowsXP(), which uses
VerifyVersionInfo()?

https://code.google.com/p/chromium/codesearch#search/&q=windowsVersion%20file...

[tkent, 2013-10-25 04:49:04]

Wow, I found IsWindowsVistaOrGreater().
http://msdn.microsoft.com/en-us/library/windows/desktop/dn424965(v=vs.85).aspx

We can remove SystemInfo.{cpp,h} entirely.

[tkent, 2013-10-25 04:50:39]

On 2013/10/25 04:49:04, tkent wrote:
> Wow, I found IsWindowsVistaOrGreater().
>
http://msdn.microsoft.com/en-us/library/windows/desktop/dn424965%28v=vs.85%29...
> 
> We can remove SystemInfo.{cpp,h} entirely.

Nevermind, it's in 8.1 SDK.

[yosin_UTC9, 2013-10-25 08:14:18]

PTAL

[dominicc (has gone to gerrit), 2013-10-25 08:34:02]

On 2013/10/25 08:14:18, Yoshifumi Inoue wrote:
> PTAL

DBC: You might like to change your commit message; Grater -> Greater.

[yosin_UTC9, 2013-10-25 08:36:28]

On 2013/10/25 08:34:02, dominicc wrote:
> On 2013/10/25 08:14:18, Yoshifumi Inoue wrote:
> > PTAL
> 
> DBC: You might like to change your commit message; Grater -> Greater.
Oops. Thanks for catching this!

[tkent, 2013-10-27 21:22:28]

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
File Source/platform/win/SystemInfo.cpp (right):

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
Source/platform/win/SystemInfo.cpp:38: // Taken from VersionHelpers.h in Windows
SDK 8.1+.
Does the Windows SDK license allow to copy/redistribute the code?

[yukawa, 2013-10-28 02:21:19]

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
File Source/platform/win/SystemInfo.cpp (right):

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
Source/platform/win/SystemInfo.cpp:64: cachedIsWindowsVistaOrGreater =
IsWindowsVistaOrGreater();
IsWindowsVersionOrGreater is just a helper wrapper of VerifyVersionInfo API. 
Let's use VerifyVersionInfo API as usual.

OSVERSIONINFOEXW osvi = {};
osvi.dwOSVersionInfoSize = sizeof(osvi);
osvi.dwMajorVersion = 6;  // Vista == Windows 6.0
osvi.dwMinorVersion = 0;  // Vista == Windows 6.0  
DWORDLONG conditoin = 0;
VER_SET_CONDITION(conditoin, VER_MAJORVERSION, VER_GREATER_EQUAL);
VER_SET_CONDITION(conditoin, VER_MINORVERSION, VER_GREATER_EQUAL);
cachedIsWindowsVistaOrGreater = !!::VerifyVersionInfoW(&osvi, VER_MAJORVERSION |
VER_MINORVERSION, conditoin);

(This code is surely written by me and can be licensed as a part of Blink)

[yosin_UTC9, 2013-10-28 04:30:59]

PTAL

Now no copyright issue.

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
File Source/platform/win/SystemInfo.cpp (right):

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
Source/platform/win/SystemInfo.cpp:38: // Taken from VersionHelpers.h in Windows
SDK 8.1+.
On 2013/10/27 21:22:28, tkent wrote:
> Does the Windows SDK license allow to copy/redistribute the code?
Not sure. So, I take yukawa@'s code.

https://codereview.chromium.org/39693002/diff/310007/Source/platform/win/Syst...
Source/platform/win/SystemInfo.cpp:64: cachedIsWindowsVistaOrGreater =
IsWindowsVistaOrGreater();
On 2013/10/28 02:21:19, yukawa wrote:
> IsWindowsVersionOrGreater is just a helper wrapper of VerifyVersionInfo API. 
> Let's use VerifyVersionInfo API as usual.
> 
> OSVERSIONINFOEXW osvi = {};
> osvi.dwOSVersionInfoSize = sizeof(osvi);
> osvi.dwMajorVersion = 6;  // Vista == Windows 6.0
> osvi.dwMinorVersion = 0;  // Vista == Windows 6.0  
> DWORDLONG conditoin = 0;
> VER_SET_CONDITION(conditoin, VER_MAJORVERSION, VER_GREATER_EQUAL);
> VER_SET_CONDITION(conditoin, VER_MINORVERSION, VER_GREATER_EQUAL);
> cachedIsWindowsVistaOrGreater = !!::VerifyVersionInfoW(&osvi, VER_MAJORVERSION
|
> VER_MINORVERSION, conditoin);
> 
> (This code is surely written by me and can be licensed as a part of Blink)
Thanks! I take yours.

[tkent, 2013-10-28 05:17:56]

lgtm

[commit-bot: I haz the power, 2013-10-28 05:18:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yosin@chromium.org/39693002/440001

[commit-bot: I haz the power, 2013-10-28 07:00:51]

Change committed as 160698