Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 732483003: Remove GestureScrollUpdateWithoutPropagation event (blink) (Closed)

Created:
6 years, 1 month ago by majidvp
Modified:
6 years ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-events_chromium.org, blink-reviews-rendering, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove GestureScrollUpdateWithoutPropagation event in blink. The event is being deprecated in favor of using GestureScrollUpdate. All relevant LayoutTests are updated to use the new method available in EventSender. This patch is part of a series: patch #1: https://codereview.chromium.org/703983002 patch #2: https://codereview.chromium.org/729533003 patch #3: This CL BUG=416596 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=186303

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 3

Patch Set 3 : Address minor nitp #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -96 lines) Patch
M LayoutTests/fast/events/touch/gesture/touch-gesture-fully-scrolled-iframe-propagates.html View 3 chunks +8 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html View 4 chunks +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html View 3 chunks +9 lines, -7 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-input-field.html View 6 chunks +15 lines, -14 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-listbox.html View 5 chunks +12 lines, -11 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/gesture-events.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/gesture-events-scrolled.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/GestureEvent.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/EventHandler.cpp View 1 2 3 5 chunks +7 lines, -8 lines 0 comments Download
M Source/core/rendering/RenderLayerScrollableArea.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/PlatformEvent.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/PlatformGestureEvent.h View 1 4 chunks +6 lines, -13 lines 0 comments Download
M Source/platform/scroll/Scrollbar.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PageWidgetDelegate.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/PopupContainer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M Source/web/WebInputEventConversion.cpp View 1 1 chunk +0 lines, -8 lines 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPopupMenuImpl.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M public/web/WebInputEvent.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
majidvp
6 years ago (2014-11-25 18:50:11 UTC) #2
Rick Byers
Nice! LGTM with nit https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp#newcode2459 Source/core/page/EventHandler.cpp:2459: gestureEvent.type() == PlatformEvent::GestureScrollUpdate && gestureEvent.preventPropagation(); ...
6 years ago (2014-11-25 19:48:02 UTC) #3
majidvp
https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp#newcode2459 Source/core/page/EventHandler.cpp:2459: gestureEvent.type() == PlatformEvent::GestureScrollUpdate && gestureEvent.preventPropagation(); On 2014/11/25 19:48:02, Rick ...
6 years ago (2014-11-25 19:58:17 UTC) #4
Rick Byers
On 2014/11/25 19:58:17, majidvp wrote: > https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp > File Source/core/page/EventHandler.cpp (right): > > https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp#newcode2459 > ...
6 years ago (2014-11-25 20:01:55 UTC) #5
majidvp
https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp File Source/core/page/EventHandler.cpp (right): https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp#newcode2459 Source/core/page/EventHandler.cpp:2459: gestureEvent.type() == PlatformEvent::GestureScrollUpdate && gestureEvent.preventPropagation(); On 2014/11/25 19:48:02, Rick ...
6 years ago (2014-11-26 14:58:35 UTC) #6
Rick Byers
On 2014/11/26 14:58:35, majidvp wrote: > https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp > File Source/core/page/EventHandler.cpp (right): > > https://codereview.chromium.org/732483003/diff/20001/Source/core/page/EventHandler.cpp#newcode2459 > ...
6 years ago (2014-11-26 15:10:41 UTC) #7
majidvp
+jochen for Source/web and Source/platform OWNERS review.
6 years ago (2014-11-28 15:34:30 UTC) #9
jochen (gone - plz use gerrit)
lgtm
6 years ago (2014-12-02 10:03:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/732483003/60001
6 years ago (2014-12-02 13:23:06 UTC) #12
commit-bot: I haz the power
6 years ago (2014-12-02 14:44:11 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=186303

Powered by Google App Engine
This is Rietveld 408576698