Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 729533003: Remove GestureScrollUpdateWithoutPropagation event (Closed)

Created:
6 years, 1 month ago by majidvp
Modified:
6 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jdduke+watch_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove GestureScrollUpdateWithoutPropagation event. EventSender now supports a new optional preventPropagation flag for gestureScrollUpdate. The old method is still available but will be removed once relevant LayoutTests in blink are updated to use the new method (CL: 732483003). This patch is part of a series: patch #1: https://codereview.chromium.org/703983002 patch #2: This CL patch #3: https://codereview.chromium.org/732483003 BUG=416596 Committed: https://crrev.com/50205db699b0e0de2274a16c7e7fba3fa0b09e2b Cr-Commit-Position: refs/heads/master@{#306003}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase and fix minor issue in input_router_impl_unittest.cc #

Total comments: 2

Patch Set 4 : remove hard count from the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -13 lines) Patch
M content/browser/android/content_view_core_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M content/common/input/gesture_event_stream_validator.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M content/shell/renderer/test_runner/event_sender.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/event_sender.cc View 1 2 5 chunks +16 lines, -3 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 17 (4 generated)
majidvp
Please review.
6 years, 1 month ago (2014-11-18 17:56:59 UTC) #2
jdduke (slow)
Nice, content lgtm.
6 years, 1 month ago (2014-11-18 19:48:38 UTC) #3
majidvp
6 years, 1 month ago (2014-11-18 21:05:23 UTC) #5
majidvp
pfeldman@: PTAL.
6 years ago (2014-11-24 14:05:57 UTC) #6
Rick Byers
On 2014/11/24 14:05:57, majidvp wrote: > pfeldman@: PTAL. +dpranke for content/shell/renderer/test_runner OWNERS Dirk has given ...
6 years ago (2014-11-26 15:13:06 UTC) #8
majidvp
On 2014/11/26 15:13:06, Rick Byers wrote: > On 2014/11/24 14:05:57, majidvp wrote: > > pfeldman@: ...
6 years ago (2014-11-26 19:11:47 UTC) #9
jdduke (slow)
https://codereview.chromium.org/729533003/diff/40001/content/browser/renderer_host/input/input_router_impl_unittest.cc File content/browser/renderer_host/input/input_router_impl_unittest.cc (right): https://codereview.chromium.org/729533003/diff/40001/content/browser/renderer_host/input/input_router_impl_unittest.cc#newcode996 content/browser/renderer_host/input/input_router_impl_unittest.cc:996: WebInputEvent::Type eventTypes[kEventTypesLength] = { Could we ditch the hard ...
6 years ago (2014-11-26 19:26:03 UTC) #10
Dirk Pranke
lgtm. Dirk already left on vacation :). Luckily, Dirk also has a poor understanding of ...
6 years ago (2014-11-26 22:50:04 UTC) #11
majidvp
https://codereview.chromium.org/729533003/diff/40001/content/browser/renderer_host/input/input_router_impl_unittest.cc File content/browser/renderer_host/input/input_router_impl_unittest.cc (right): https://codereview.chromium.org/729533003/diff/40001/content/browser/renderer_host/input/input_router_impl_unittest.cc#newcode996 content/browser/renderer_host/input/input_router_impl_unittest.cc:996: WebInputEvent::Type eventTypes[kEventTypesLength] = { On 2014/11/26 19:26:03, jdduke wrote: ...
6 years ago (2014-11-27 15:47:55 UTC) #12
jdduke (slow)
On 2014/11/27 15:47:55, majidvp wrote: > https://codereview.chromium.org/729533003/diff/40001/content/browser/renderer_host/input/input_router_impl_unittest.cc > File content/browser/renderer_host/input/input_router_impl_unittest.cc (right): > > https://codereview.chromium.org/729533003/diff/40001/content/browser/renderer_host/input/input_router_impl_unittest.cc#newcode996 > ...
6 years ago (2014-11-27 15:58:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729533003/60001
6 years ago (2014-11-27 16:34:03 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years ago (2014-11-27 17:29:03 UTC) #16
commit-bot: I haz the power
6 years ago (2014-11-27 17:29:54 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/50205db699b0e0de2274a16c7e7fba3fa0b09e2b
Cr-Commit-Position: refs/heads/master@{#306003}

Powered by Google App Engine
This is Rietveld 408576698