Add preventPropagation bit to GestureScrollUpdate event

Add preventPropagation flag to GestureScrollUpdate event

This is in preparation for the removal of GestureScrollUpdateWithoutPropagation 
event. The new flag is stored in a int due to alignment requirements of
WebInputEvent class.

All related tests will be updated in a separate CL because they depend on
EventSender updates which lives outside blink and depends on this CL.

follow-up patch #2: https://codereview.chromium.org/729533003
follow-up patch #3: https://codereview.chromium.org/732483003

BUG=416596
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185685

[majidvp, 2014-11-06 16:32:58]

Patchset #2 (id:20001) has been deleted

[majidvp, 2014-11-11 22:20:39]

majidvp@chromium.org changed reviewers:
+ rbyers@chromium.org

[majidvp, 2014-11-11 22:20:40]

Ready for review.

[Rick Byers, 2014-11-14 18:21:45]

Looks good, thanks.

Please upload versions of your follow-up patches (even if they're not ready for
review yet) and add links to them in the description.  This will make it easier
for someone to connect the pieces from the log after submission.

Also minor nit: replace 'ScrollUpdate' in the description with
'GestureScrollUpdate'.  This is about touch (gestures) specifically (not all
scrolling).

https://codereview.chromium.org/703983002/diff/60001/Source/web/tests/WebInpu...
File Source/web/tests/WebInputEventConversionTest.cpp (right):

https://codereview.chromium.org/703983002/diff/60001/Source/web/tests/WebInpu...
Source/web/tests/WebInputEventConversionTest.cpp:394: PlatformGestureEvent
platformGestureEvent(PlatformEvent::GestureScrollUpdate, IntPoint(10, 10),
IntPoint(10, 10), IntSize(10, 10), 0, false, false, false, false, 10, 10, 10,
10, false);
You can add a conversion unit test now that sets this bit to true, right?  Might
as well do that.

[majidvp, 2014-11-17 21:33:03]

Update test and issue description to address comments.

https://codereview.chromium.org/703983002/diff/60001/Source/web/tests/WebInpu...
File Source/web/tests/WebInputEventConversionTest.cpp (right):

https://codereview.chromium.org/703983002/diff/60001/Source/web/tests/WebInpu...
Source/web/tests/WebInputEventConversionTest.cpp:394: PlatformGestureEvent
platformGestureEvent(PlatformEvent::GestureScrollUpdate, IntPoint(10, 10),
IntPoint(10, 10), IntSize(10, 10), 0, false, false, false, false, 10, 10, 10,
10, false);
On 2014/11/14 18:21:45, Rick Byers wrote:
> You can add a conversion unit test now that sets this bit to true, right? 
Might
> as well do that.

Good point. The conversion from PlatformGestureEvent to GestureEvent actually
drops the preventPropagation bit (same for velocityX, velocityY fields). So the
flag is never transferred to the final WebGestureEvent object. I modified the
test to set the initial flag as 'true' and assert that the final value is indeed
'false'. I think testing the false->false case does not add any additional value
as it verifies a trivial initialization logic which is already covered by this
test too.

Also updated the test covering the reverse conversion (WebGestureEvent ->
PlatformGestureEvent) to set and verify the preventPropagation flag to a non
default value 'true'.

[Rick Byers, 2014-11-17 22:37:00]

Thanks, LGTM with nit

https://codereview.chromium.org/703983002/diff/80001/Source/web/tests/WebInpu...
File Source/web/tests/WebInputEventConversionTest.cpp (right):

https://codereview.chromium.org/703983002/diff/80001/Source/web/tests/WebInpu...
Source/web/tests/WebInputEventConversionTest.cpp:410: EXPECT_EQ(0,
webGestureBuilder.data.scrollUpdate.velocityX);
nit: add a comment above these lines saying that velocity/preventPropagation
currently isn't supported by GestureEvent.  This might be a bug, I'm not sure.

[Rick Byers, 2014-11-17 22:37:09]

rbyers@chromium.org changed reviewers:
+ aelias@chromium.org

[Rick Byers, 2014-11-17 22:37:59]

rbyers@chromium.org changed reviewers:
+ vollick@chromium.org

[Rick Byers, 2014-11-17 22:38:00]

+aelias for OWNERS in Source/web
+vollick for OWNERS in Source/platform

[aelias_OOO_until_Jul13, 2014-11-17 22:46:01]

lgtm

[Ian Vollick, 2014-11-17 22:54:51]

On 2014/11/17 22:46:01, aelias wrote:
> lgtm

lgtm

[majidvp, 2014-11-18 15:49:41]

https://codereview.chromium.org/703983002/diff/80001/Source/web/tests/WebInpu...
File Source/web/tests/WebInputEventConversionTest.cpp (right):

https://codereview.chromium.org/703983002/diff/80001/Source/web/tests/WebInpu...
Source/web/tests/WebInputEventConversionTest.cpp:410: EXPECT_EQ(0,
webGestureBuilder.data.scrollUpdate.velocityX);
On 2014/11/17 22:37:00, Rick Byers wrote:
> nit: add a comment above these lines saying that velocity/preventPropagation
> currently isn't supported by GestureEvent.  This might be a bug, I'm not sure.

Done.

[Rick Byers, 2014-11-18 16:24:52]

On 2014/11/18 15:49:41, majidvp wrote:
>
https://codereview.chromium.org/703983002/diff/80001/Source/web/tests/WebInpu...
> File Source/web/tests/WebInputEventConversionTest.cpp (right):
> 
>
https://codereview.chromium.org/703983002/diff/80001/Source/web/tests/WebInpu...
> Source/web/tests/WebInputEventConversionTest.cpp:410: EXPECT_EQ(0,
> webGestureBuilder.data.scrollUpdate.velocityX);
> On 2014/11/17 22:37:00, Rick Byers wrote:
> > nit: add a comment above these lines saying that velocity/preventPropagation
> > currently isn't supported by GestureEvent.  This might be a bug, I'm not
sure.
> 
> Done.

Thanks, still LGTM.  Looks like you need to merge with trunk though.

[majidvp, 2014-11-20 17:28:26]

The CQ bit was checked by majidvp@chromium.org

[majidvp, 2014-11-20 17:28:27]

The CQ bit was unchecked by majidvp@chromium.org

[majidvp, 2014-11-20 17:32:34]

The CQ bit was checked by majidvp@chromium.org

[majidvp, 2014-11-20 17:32:35]

The CQ bit was unchecked by majidvp@chromium.org

[majidvp, 2014-11-20 17:32:44]

The CQ bit was checked by majidvp@chromium.org

[commit-bot: I haz the power, 2014-11-20 17:33:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/703983002/120001

[commit-bot: I haz the power, 2014-11-20 18:12:35]

Committed patchset #6 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185685