Use the request URL as the URL of the resources which are fetched ServiceWorker [3/3 blink]

Use the request URL as the URL of the resources which are fetched ServiceWorker [3/3 blink]

1/3 blink: https://codereview.chromium.org/732963003
 - Intorduce originalURLViaServiceWorker in ResourceResponse and WebURLResponse
 - Change CSP check to use originalURLViaServiceWorker if exists in ResourceFetcher::didReceiveResponse().
2/3 chromium: https://codereview.chromium.org/731983003
 - Stop updating the request's URL in ResourceDispatcher::OnReceivedResponse() and WebURLLoaderImpl::Context::OnReceivedResponse().
 - Set WebURLResponse's originalURLViaServiceWorker in WebURLLoaderImpl::PopulateURLResponse().
3/3 blink: https://codereview.chromium.org/732003002 [THIS PATCH]
 - Change CSP check to use originalURLViaServiceWorker.
 - Add LayoutTest for this bug.

BUG=433743
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185751

[horo, 2014-11-17 08:12:09]

horo@chromium.org changed reviewers:
+ yhirano@chromium.org

[horo, 2014-11-17 08:12:10]

yhirano@
Could you please review?

[yhirano, 2014-11-19 04:06:21]

https://codereview.chromium.org/732003002/diff/1/Source/core/fetch/ResourceFe...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/732003002/diff/1/Source/core/fetch/ResourceFe...
Source/core/fetch/ResourceFetcher.cpp:1350: // If the response is fetched via
ServiceWorker, the original URL of the response could be different from the URL
of the request.
Can you add a comment here that this check aims not to fetch a resource that are
forbidden by the page CSP even in the service worker, and it is not specified
currently?

[horo, 2014-11-19 04:37:59]

Patchset #2 (id:20001) has been deleted

[horo, 2014-11-19 04:56:00]

https://codereview.chromium.org/732003002/diff/1/Source/core/fetch/ResourceFe...
File Source/core/fetch/ResourceFetcher.cpp (right):

https://codereview.chromium.org/732003002/diff/1/Source/core/fetch/ResourceFe...
Source/core/fetch/ResourceFetcher.cpp:1350: // If the response is fetched via
ServiceWorker, the original URL of the response could be different from the URL
of the request.
On 2014/11/19 04:06:21, yhirano wrote:
> Can you add a comment here that this check aims not to fetch a resource that
are
> forbidden by the page CSP even in the service worker, and it is not specified
> currently?

Done.

[yhirano, 2014-11-19 05:11:20]

lgtm

[horo, 2014-11-19 06:31:13]

horo@chromium.org changed reviewers:
+ mkwst@chromium.org

[horo, 2014-11-19 06:31:14]

mkwst@
Could you please review this?

[Mike West, 2014-11-19 10:01:10]

On 2014/11/19 06:31:14, horo wrote:
> mkwst@
> Could you please review this?

Happily, but let's poke a bit at the security implications in the conversation I
started on the other CL.

[Mike West, 2014-11-20 07:58:17]

LGTM, as discussed on the other bug.

[horo, 2014-11-21 00:05:14]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-11-21 00:07:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/732003002/40001

[commit-bot: I haz the power, 2014-11-21 00:19:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-21 00:19:18]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/2...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/32006)

[horo, 2014-11-21 01:32:15]

The CQ bit was checked by horo@chromium.org

[commit-bot: I haz the power, 2014-11-21 01:32:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/732003002/40001

[commit-bot: I haz the power, 2014-11-21 03:57:48]

Committed patchset #2 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185751