Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 731983003: Use the request URL as the URL of the resources which are fetched ServiceWorker [2/3 chromium] (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use the request URL as the URL of the resources which are fetched ServiceWorker [2/3 chromium] 1/3 blink: https://codereview.chromium.org/732963003 - Intorduce originalURLViaServiceWorker in ResourceResponse and WebURLResponse - Change CSP check to use originalURLViaServiceWorker if exists in ResourceFetcher::didReceiveResponse(). 2/3 chromium: https://codereview.chromium.org/731983003 [THIS PATCH] - Stop updating the request's URL in ResourceDispatcher::OnReceivedResponse() and WebURLLoaderImpl::Context::OnReceivedResponse(). - Set WebURLResponse's originalURLViaServiceWorker in WebURLLoaderImpl::PopulateURLResponse(). 3/3 blink: https://codereview.chromium.org/732003002 - Change CSP check to use originalURLViaServiceWorker. - Add LayoutTest for this bug. BUG=433743 Committed: https://crrev.com/20db5d6d857f499d786f6e08ecb64daec089fddc Cr-Commit-Position: refs/heads/master@{#305075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M content/child/resource_dispatcher.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M content/child/web_url_loader_impl.cc View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
horo
yhirano@ Could you please review?
6 years, 1 month ago (2014-11-17 08:11:58 UTC) #2
yhirano
lgtm
6 years, 1 month ago (2014-11-19 04:06:46 UTC) #3
horo
jochen@ Could you please review this?
6 years, 1 month ago (2014-11-19 06:31:11 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 1 month ago (2014-11-19 08:47:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731983003/1
6 years, 1 month ago (2014-11-20 18:49:29 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-20 20:33:44 UTC) #11
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 20:35:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20db5d6d857f499d786f6e08ecb64daec089fddc
Cr-Commit-Position: refs/heads/master@{#305075}

Powered by Google App Engine
This is Rietveld 408576698