[DevTools] Remote frontend is now embedded to iframe.

[DevTools] Remote frontend is now embedded to iframe.

Remote protocol handler should now report "inspector.html".

BUG=431697
Committed: https://crrev.com/a1409c477411b0467b4bc729d9a2c972e79347d1
Cr-Commit-Position: refs/heads/master@{#304820}

[dgozman, 2014-11-14 14:13:02]

dgozman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[dgozman, 2014-11-14 14:13:03]

Take a look please.

[mnaganov (inactive), 2014-11-14 16:20:30]

mnaganov@chromium.org changed reviewers:
+ mnaganov@chromium.org

[mnaganov (inactive), 2014-11-14 16:20:30]

Please postpone landing until I check what we need to do on the "cloud frontend"
side for AppCache. Currently we need a magic "FALLBACK" entry in the manifest
for "devtools.html", to enforce all requests that have query parameters
"..devtools.html?blah-blah" to go directly to AppCache instead of checking the
cloud first. Probably, we will now need an entry for "inspector.html" too.

See e.g.
https://chrome-devtools-frontend.appspot.com/serve_rev/@183548/183548.manifest :

CACHE MANIFEST
FALLBACK:
devtools.html devtools.html

[dgozman, 2014-11-14 16:48:54]

On 2014/11/14 16:20:30, mnaganov (cr) wrote:
> Please postpone landing until I check what we need to do on the "cloud
frontend"
> side for AppCache. Currently we need a magic "FALLBACK" entry in the manifest
> for "devtools.html", to enforce all requests that have query parameters
> "..devtools.html?blah-blah" to go directly to AppCache instead of checking the
> cloud first. Probably, we will now need an entry for "inspector.html" too.
> 
> See e.g.
> https://chrome-devtools-frontend.appspot.com/serve_rev/@183548/183548.manifest
:
> 
> CACHE MANIFEST
> FALLBACK:
> devtools.html devtools.html

Sure. In fact, we will only need inspector.html in the future (at least, that's
the plan), but for now we should mention both there.

[mnaganov (inactive), 2014-11-15 01:09:46]

On 2014/11/14 16:48:54, dgozman wrote:
> On 2014/11/14 16:20:30, mnaganov (cr) wrote:
> > Please postpone landing until I check what we need to do on the "cloud
> frontend"
> > side for AppCache. Currently we need a magic "FALLBACK" entry in the
manifest
> > for "devtools.html", to enforce all requests that have query parameters
> > "..devtools.html?blah-blah" to go directly to AppCache instead of checking
the
> > cloud first. Probably, we will now need an entry for "inspector.html" too.
> > 
> > See e.g.
> >
https://chrome-devtools-frontend.appspot.com/serve_rev/@183548/183548.manifest
> :
> > 
> > CACHE MANIFEST
> > FALLBACK:
> > devtools.html devtools.html
> 
> Sure. In fact, we will only need inspector.html in the future (at least,
that's
> the plan), but for now we should mention both there.

Yes. Adding both of them works OK, no problem with that. I will also update the
script that injects the reference to the manifest into the main .html file --
inspector.html in this case. So go ahead.

[pfeldman, 2014-11-17 12:11:33]

lgtm

[dgozman, 2014-11-17 15:34:49]

dgozman@chromium.org changed reviewers:
+ dtrainor@chromium.org, gunsch@chromium.org

[dgozman, 2014-11-17 15:34:50]

Hello folks,

Could you please take a look at:

mnaganov@ - at android_webview/;
gunsch@ - at chromecast/;
dtrainor@ - at chrome/browser/android;

Thanks,
Dmitry

[mnaganov (inactive), 2014-11-17 15:46:06]

android_webview LGTM

[gunsch, 2014-11-17 15:49:25]

chromecast/ lgtm

[David Trainor- moved to gerrit, 2014-11-17 18:35:29]

chrome/browser/android lgtm

[dgozman, 2014-11-19 12:57:11]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-11-19 12:58:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/730433003/1

[commit-bot: I haz the power, 2014-11-19 13:58:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-19 13:58:21]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2014-11-19 15:07:06]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2014-11-19 15:08:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/730433003/20001

[commit-bot: I haz the power, 2014-11-19 16:06:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-19 16:07:13]

Patchset 2 (id:??) landed as
https://crrev.com/a1409c477411b0467b4bc729d9a2c972e79347d1
Cr-Commit-Position: refs/heads/master@{#304820}