chrome/browser/devtools/devtools_window.h - Issue 730433003: [DevTools] Remote frontend is now embedded to iframe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 730433003: [DevTools] Remote frontend is now embedded to iframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased, fixed test Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/devtools/devtools_window.h

diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h

index 905ede72a3ed667e735444920c7d4c70a6fce1d0..aa90fe69fdd8210c4484a3c37bac0597c1d48ad4 100644

--- a/chrome/browser/devtools/devtools_window.h

+++ b/chrome/browser/devtools/devtools_window.h

@@ -207,13 +207,13 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,

const GURL& frontend_url,

content::WebContents* inspected_web_contents,

bool shared_worker_frontend,

- bool external_frontend,

+ const std::string& remote_frontend,

bool can_dock,

const std::string& settings);

static GURL GetDevToolsURL(Profile* profile,

const GURL& base_url,

bool shared_worker_frontend,

- bool external_frontend,

+ const std::string& remote_frontend,

bool can_dock,

const std::string& settings);

static DevToolsWindow* FindDevToolsWindow(content::DevToolsAgentHost*);

« no previous file with comments | « chrome/browser/android/dev_tools_server.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »