Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: content/shell/browser/shell_devtools_manager_delegate.cc

Issue 730433003: [DevTools] Remote frontend is now embedded to iframe. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased, fixed test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/shell/browser/shell_devtools_manager_delegate.h" 5 #include "content/shell/browser/shell_devtools_manager_delegate.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 20 matching lines...) Expand all
31 #include "content/public/browser/android/devtools_auth.h" 31 #include "content/public/browser/android/devtools_auth.h"
32 #include "net/socket/unix_domain_server_socket_posix.h" 32 #include "net/socket/unix_domain_server_socket_posix.h"
33 #endif 33 #endif
34 34
35 namespace content { 35 namespace content {
36 36
37 namespace { 37 namespace {
38 38
39 #if defined(OS_ANDROID) 39 #if defined(OS_ANDROID)
40 const char kFrontEndURL[] = 40 const char kFrontEndURL[] =
41 "http://chrome-devtools-frontend.appspot.com/serve_rev/%s/devtools.html"; 41 "http://chrome-devtools-frontend.appspot.com/serve_rev/%s/inspector.html";
42 #endif 42 #endif
43 const char kTargetTypePage[] = "page"; 43 const char kTargetTypePage[] = "page";
44 const char kTargetTypeServiceWorker[] = "service_worker"; 44 const char kTargetTypeServiceWorker[] = "service_worker";
45 const char kTargetTypeOther[] = "other"; 45 const char kTargetTypeOther[] = "other";
46 46
47 #if defined(OS_ANDROID) 47 #if defined(OS_ANDROID)
48 class UnixDomainServerSocketFactory 48 class UnixDomainServerSocketFactory
49 : public DevToolsHttpHandler::ServerSocketFactory { 49 : public DevToolsHttpHandler::ServerSocketFactory {
50 public: 50 public:
51 explicit UnixDomainServerSocketFactory(const std::string& socket_name) 51 explicit UnixDomainServerSocketFactory(const std::string& socket_name)
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
271 271
272 void ShellDevToolsManagerDelegate::EnumerateTargets(TargetCallback callback) { 272 void ShellDevToolsManagerDelegate::EnumerateTargets(TargetCallback callback) {
273 TargetList targets; 273 TargetList targets;
274 for (const auto& agent_host : DevToolsAgentHost::GetOrCreateAll()) { 274 for (const auto& agent_host : DevToolsAgentHost::GetOrCreateAll()) {
275 targets.push_back(new Target(agent_host)); 275 targets.push_back(new Target(agent_host));
276 } 276 }
277 callback.Run(targets); 277 callback.Run(targets);
278 } 278 }
279 279
280 } // namespace content 280 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/devtools/devtools_http_handler_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698