Disallow background tabs without matching user gesture for createWindow()

Disallow background tabs without matching user gesture for createWindow()

BUG=431335
R=mkwst@chromium.org
TEST=content_shell doesn't do tabs, so no tests

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185430

[Mike West, 2014-11-17 09:43:32]

LGTM.

https://codereview.chromium.org/730013002/diff/1/Source/web/ChromeClientImpl.cpp
File Source/web/ChromeClientImpl.cpp (right):

https://codereview.chromium.org/730013002/diff/1/Source/web/ChromeClientImpl....
Source/web/ChromeClientImpl.cpp:307: policy =
WebNavigationPolicyNewForegroundTab;
Nit: Maybe extract this out to a helper so you don't repeat yourself? Up to you.

[jochen (gone - plz use gerrit), 2014-11-17 09:44:16]

nah

[jochen (gone - plz use gerrit), 2014-11-17 09:44:20]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2014-11-17 09:45:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/730013002/1

[jochen (gone - plz use gerrit), 2014-11-17 10:01:45]

Dear gardeners, the browser tests breakage will be fixed by
https://codereview.chromium.org/731083002

[jochen (gone - plz use gerrit), 2014-11-17 10:06:01]

actually, i'll just temporary disable the failing tests and wait for the roll

[commit-bot: I haz the power, 2014-11-17 10:56:01]

Committed patchset #1 (id:1) as 185430