Disallow background tabs without matching user gesture for createWindow()

Source/web/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 211 matching lines @@
 
 Page* ChromeClientImpl::createWindow(LocalFrame* frame, const FrameLoadRequest& r, const WindowFeatures& features,
     NavigationPolicy navigationPolicy, ShouldSendReferrer shouldSendReferrer)
 {
     if (!m_webView->client())
         return 0;
 
     WebNavigationPolicy policy = static_cast<WebNavigationPolicy>(navigationPolicy);
     if (policy == WebNavigationPolicyIgnore)
         policy = getNavigationPolicy();
+    else if (policy == WebNavigationPolicyNewBackgroundTab && getNavigationPolicy() != WebNavigationPolicyNewBackgroundTab)
+        policy = WebNavigationPolicyNewForegroundTab;
 
     ASSERT(frame->document());
     Fullscreen::fullyExitFullscreen(*frame->document());
 
     WebViewImpl* newView = toWebViewImpl(
         m_webView->client()->createView(WebLocalFrameImpl::fromFrame(frame), WrappedResourceRequest(r.resourceRequest()), features, r.frameName(), policy, shouldSendReferrer == NeverSendReferrer));
     if (!newView)
         return 0;
     return newView->page();
 }
@@ skipping 52 matching lines @@
 }
 
 void ChromeClientImpl::show(NavigationPolicy navigationPolicy)
 {
     if (!m_webView->client())
         return;
 
     WebNavigationPolicy policy = static_cast<WebNavigationPolicy>(navigationPolicy);
     if (policy == WebNavigationPolicyIgnore)
         policy = getNavigationPolicy();
+    else if (policy == WebNavigationPolicyNewBackgroundTab && getNavigationPolicy() != WebNavigationPolicyNewBackgroundTab)
+        policy = WebNavigationPolicyNewForegroundTab;

[Mike West, 2014/11/17 09:43:32]

Nit: Maybe extract this out to a helper so you don't repeat yourself? Up to you.

     m_webView->client()->show(policy);
 }
 
 bool ChromeClientImpl::canRunModal()
 {
     return !!m_webView->client();
 }
 
 void ChromeClientImpl::runModal()
 {
@@ skipping 537 matching lines @@
         m_webView->autofillClient()->textFieldDidEndEditing(WebInputElement(&inputElement));
 }
 
 void ChromeClientImpl::openTextDataListChooser(HTMLInputElement& input)
 {
     if (m_webView->autofillClient())
         m_webView->autofillClient()->openTextDataListChooser(WebInputElement(&input));
 }
 
 } // namespace blink