Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 731083002: Update popup blocker behavior and tests (Closed)

Created:
6 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
6 years, 1 month ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Update popup blocker behavior and tests The tests now also check whether a background or foreground tab is opened. We also make the behavior of the popup blocker match the behavior of the render view (which is to not mess with the disposition) BUG=431335 R=mkwst@chromium.org Committed: https://crrev.com/7c3b40a06e92cd393f6e36812399c8976ca93486 Cr-Commit-Position: refs/heads/master@{#304593}

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Patch Set 4 : updates #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M chrome/browser/ui/blocked_content/blocked_window_params.cc View 1 chunk +1 line, -5 lines 0 comments Download
M chrome/browser/ui/blocked_content/popup_blocker_browsertest.cc View 1 2 3 4 9 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
jochen (gone - plz use gerrit)
6 years, 1 month ago (2014-11-17 09:59:03 UTC) #1
Mike West
LGTM.
6 years, 1 month ago (2014-11-17 10:01:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731083002/20001
6 years, 1 month ago (2014-11-17 16:15:49 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6236)
6 years, 1 month ago (2014-11-17 17:18:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731083002/40001
6 years, 1 month ago (2014-11-17 20:43:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/6348)
6 years, 1 month ago (2014-11-17 22:08:59 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731083002/60001
6 years, 1 month ago (2014-11-18 11:53:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/731083002/80001
6 years, 1 month ago (2014-11-18 12:52:00 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years, 1 month ago (2014-11-18 13:33:33 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 13:34:20 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7c3b40a06e92cd393f6e36812399c8976ca93486
Cr-Commit-Position: refs/heads/master@{#304593}

Powered by Google App Engine
This is Rietveld 408576698