Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 729103002: Revert of DirectWrite Font Cache browser side hookup (Closed)

Created:
6 years, 1 month ago by scottmg
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of DirectWrite Font Cache browser side hookup (patchset #5 id:80001 of https://codereview.chromium.org/724633002/) Reason for revert: Seems to be flaking occasionally, see e.g. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/32711/steps/browser_tests/logs/stdio @@@STEP_LOG_LINE@UnchangedCustom_1@PrefHashBrowserTestUnchangedCustomInstance/PrefHashBrowserTestUnchangedCustom.UnchangedCustom/1 (run #4):@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@[ RUN ] PrefHashBrowserTestUnchangedCustomInstance/PrefHashBrowserTestUnchangedCustom.UnchangedCustom/1@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@[3308:4824:1114/190930:WARNING:data_reduction_proxy_settings.cc(328)] SPDY proxy OFF at startup@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@[4200:5032:1114/190932:FATAL:dwrite_font_platform_win.cc(493)] Check failed: false.@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@Backtrace:@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@ base::DiscardableMemoryShmemAllocator::~DiscardableMemoryShmemAllocator [0x10099E01+538517]@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@ base::DiscardableMemoryShmemAllocator::~DiscardableMemoryShmemAllocator [0x10129E1F+1128371]@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@ content::WebContentsImpl::WasShown [0x1326A46D+21053350]@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@ DWriteCreateFactory [0x6D494A06+363338]@@@ @@@STEP_LOG_LINE@UnchangedCustom_1@ DWriteCreateFactory [0x6D49402C+360816]@@@ Original issue's description: > DirectWrite Font Cache browser side hookup > This part is mainly to hookup browser side for building and loading font cache. > In browser's postprofileinit if font cache already exists in user profile directory > then we load that and create a read only shared memory section. If cache is not there > then we spawn a Chrome utility process to build font cache, which will be used when browser restarts. > > For details on how whole thing works please look at design document at https://goto.google.com/font-cache-design > > BUG=406659 > R=cpu, scottmg, ananta > > Committed: https://crrev.com/5140a1f1ba5bd57d5c7d9af04ed3eb8ac83f487d > Cr-Commit-Position: refs/heads/master@{#304277} TBR=ananta@chromium.org,cpu@chromium.org,shrikant@chromium.org NOTREECHECKS=true NOTRY=true BUG=406659 Committed: https://crrev.com/251b3d34c15a0b7745f9fd40f0375e1fd1eedbef Cr-Commit-Position: refs/heads/master@{#304349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -145 lines) Patch
M chrome/browser/chrome_browser_main_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 6 chunks +0 lines, -32 lines 0 comments Download
M chrome/chrome_utility.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_utility_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/utility/font_cache_handler_win.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/utility/font_cache_handler_win.cc View 1 chunk +0 lines, -24 lines 0 comments Download
A content/browser/dwrite_font_cache_win.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -3 lines 0 comments Download
A content/common/dwrite_font_platform_win.h View 1 chunk +38 lines, -0 lines 0 comments Download
M content/common/dwrite_font_platform_win.cc View 3 chunks +8 lines, -3 lines 0 comments Download
M content/common/dwrite_font_platform_win_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -1 line 0 comments Download
A content/public/common/dwrite_font_cache_win.h View 1 chunk +19 lines, -0 lines 0 comments Download
D content/public/common/dwrite_font_platform_win.h View 1 chunk +0 lines, -41 lines 0 comments Download
M content/renderer/render_font_warmup_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scottmg
Created Revert of DirectWrite Font Cache browser side hookup
6 years, 1 month ago (2014-11-15 04:03:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/729103002/1
6 years, 1 month ago (2014-11-15 04:04:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-15 04:05:12 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 04:06:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/251b3d34c15a0b7745f9fd40f0375e1fd1eedbef
Cr-Commit-Position: refs/heads/master@{#304349}

Powered by Google App Engine
This is Rietveld 408576698