Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3906)

Unified Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/scripts/jsdoc-validator/tests/golden.dat
diff --git a/Source/devtools/scripts/jsdoc-validator/tests/golden.dat b/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
index a736407921b9abb699bed848a4ccdd930c12e1e1..b822ae01633ed7ba1cb2c698c53cc844a8a686ce 100644
--- a/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
+++ b/Source/devtools/scripts/jsdoc-validator/tests/golden.dat
@@ -54,6 +54,18 @@ self.addEventListener();
self.removeEventListener();
^
+/tests/document.js:59: ERROR - Access to "requestAnimationFrame" property of global object is disallowed
+self.requestAnimationFrame();
+ ^
+
+/tests/document.js:60: ERROR - Access to "cancelAnimationFrame" property of global object is disallowed
+window.cancelAnimationFrame();
+ ^
+
+/tests/document.js:61: ERROR - Access to "getSelection" property of global object is disallowed
+getSelection();
+^
+
/tests/function.js:1: ERROR - @return annotation is required for API functions that return value
function badFuncNoAnnotation() {
^
@@ -394,4 +406,4 @@ NS.BadSubClass = function() {}
function callbackNotReferencingThisAnnotated()
^
-Total errors: 99
+Total errors: 102

Powered by Google App Engine
This is Rietveld 408576698