Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/devtools/scripts/jsdoc-validator/tests/golden.dat

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/scripts/jsdoc-validator/tests/document.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /tests/document.js:1: ERROR - Access to "document" property of global object is disallowed 1 /tests/document.js:1: ERROR - Access to "document" property of global object is disallowed
2 document.bar(); 2 document.bar();
3 ^ 3 ^
4 4
5 /tests/document.js:2: ERROR - Access to "document" property of global object is disallowed 5 /tests/document.js:2: ERROR - Access to "document" property of global object is disallowed
6 window.document.bar(); 6 window.document.bar();
7 ^ 7 ^
8 8
9 /tests/document.js:5: ERROR - Access to "document" property of global object is disallowed 9 /tests/document.js:5: ERROR - Access to "document" property of global object is disallowed
10 document(); 10 document();
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 ^ 47 ^
48 48
49 /tests/document.js:57: ERROR - Access to "addEventListener" property of global o bject is disallowed 49 /tests/document.js:57: ERROR - Access to "addEventListener" property of global o bject is disallowed
50 self.addEventListener(); 50 self.addEventListener();
51 ^ 51 ^
52 52
53 /tests/document.js:58: ERROR - Access to "removeEventListener" property of globa l object is disallowed 53 /tests/document.js:58: ERROR - Access to "removeEventListener" property of globa l object is disallowed
54 self.removeEventListener(); 54 self.removeEventListener();
55 ^ 55 ^
56 56
57 /tests/document.js:59: ERROR - Access to "requestAnimationFrame" property of glo bal object is disallowed
58 self.requestAnimationFrame();
59 ^
60
61 /tests/document.js:60: ERROR - Access to "cancelAnimationFrame" property of glob al object is disallowed
62 window.cancelAnimationFrame();
63 ^
64
65 /tests/document.js:61: ERROR - Access to "getSelection" property of global objec t is disallowed
66 getSelection();
67 ^
68
57 /tests/function.js:1: ERROR - @return annotation is required for API functions t hat return value 69 /tests/function.js:1: ERROR - @return annotation is required for API functions t hat return value
58 function badFuncNoAnnotation() { 70 function badFuncNoAnnotation() {
59 ^ 71 ^
60 72
61 /tests/function.js:8: ERROR - @return annotation found, yet function does not re turn value 73 /tests/function.js:8: ERROR - @return annotation found, yet function does not re turn value
62 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation. 74 function badFuncAnnotatedButNoReturn() // ERROR - no @return annotation.
63 ^ 75 ^
64 76
65 /tests/function.js:15: ERROR - @return annotation found, yet function does not r eturn value 77 /tests/function.js:15: ERROR - @return annotation found, yet function does not r eturn value
66 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value. 78 function badFuncAnnotatedButNoReturnValue() // ERROR - no returned value.
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
387 ^ 399 ^
388 400
389 /tests/this.js:268: ERROR - @this annotation is required for functions referenci ng 'this' 401 /tests/this.js:268: ERROR - @this annotation is required for functions referenci ng 'this'
390 function callbackReferencingThisNotAnnotated() 402 function callbackReferencingThisNotAnnotated()
391 ^ 403 ^
392 404
393 /tests/this.js:277: ERROR - @this annotation found for function not referencing 'this' 405 /tests/this.js:277: ERROR - @this annotation found for function not referencing 'this'
394 function callbackNotReferencingThisAnnotated() 406 function callbackNotReferencingThisAnnotated()
395 ^ 407 ^
396 408
397 Total errors: 99 409 Total errors: 102
OLDNEW
« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/scripts/jsdoc-validator/tests/document.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698