Source/devtools/front_end/profiler/CPUProfileFlameChart.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/profiler/CPUProfileFlameChart.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/platform/DOMExtension.js ('k') | Source/devtools/front_end/resources/DatabaseQueryView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/profiler/CPUProfileFlameChart.js

diff --git a/Source/devtools/front_end/profiler/CPUProfileFlameChart.js b/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

index 29cfcc45da46a2842fca10e0f37ea46ed2c8b7ba..239b4a12e6a44a354d07a9e7dfaf5f8b28dca490 100644

--- a/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

+++ b/Source/devtools/front_end/profiler/CPUProfileFlameChart.js

@@ -657,7 +657,7 @@ WebInspector.CPUProfileFlameChart.OverviewPane.prototype = {

{

if (this._updateTimerId)

return;

- this._updateTimerId = requestAnimationFrame(this.update.bind(this));

+ this._updateTimerId = this.element.window().requestAnimationFrame(this.update.bind(this));

apavlov 2014/11/15 09:57:18 Can we define this as a shortcut on WI.View, too?

dgozman 2014/11/15 11:46:25 The less thoughtful the shortcut, the easier it wo

update: function()

« no previous file with comments | « Source/devtools/front_end/platform/DOMExtension.js ('k') | Source/devtools/front_end/resources/DatabaseQueryView.js » ('j') | no next file with comments »