Source/devtools/front_end/sources/NavigatorView.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/sources/NavigatorView.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/front_end/resources/DatabaseQueryView.js ('k') | Source/devtools/front_end/toolbox/InspectedPagePlaceholder.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/sources/NavigatorView.js

diff --git a/Source/devtools/front_end/sources/NavigatorView.js b/Source/devtools/front_end/sources/NavigatorView.js

index 99f19913edbfc22922074c4147d9c85ad8f0efcb..01e5189aa38cf0bede83d1399fafe75e2fbfcd3c 100644

--- a/Source/devtools/front_end/sources/NavigatorView.js

+++ b/Source/devtools/front_end/sources/NavigatorView.js

@@ -1301,7 +1301,7 @@ WebInspector.NavigatorUISourceCodeTreeNode.prototype = {

var editingConfig = new WebInspector.InplaceEditor.Config(commitHandler.bind(this), cancelHandler.bind(this));

this.updateTitle(true);

WebInspector.InplaceEditor.startEditing(this._treeElement.titleElement, editingConfig);

- window.getSelection().setBaseAndExtent(this._treeElement.titleElement, 0, this._treeElement.titleElement, 1);

+ treeOutlineElement.window().getSelection().setBaseAndExtent(this._treeElement.titleElement, 0, this._treeElement.titleElement, 1);

__proto__: WebInspector.NavigatorTreeNode.prototype