Source/devtools/front_end/resources/DatabaseQueryView.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/resources/DatabaseQueryView.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('K') | « Source/devtools/front_end/profiler/CPUProfileFlameChart.js ('k') | Source/devtools/front_end/sources/NavigatorView.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/resources/DatabaseQueryView.js

diff --git a/Source/devtools/front_end/resources/DatabaseQueryView.js b/Source/devtools/front_end/resources/DatabaseQueryView.js

index 3f73df68ea78a57e56f176298be0122b57811235..42e168711a38591b113edb3c8d77a186f889b452 100644

--- a/Source/devtools/front_end/resources/DatabaseQueryView.js

+++ b/Source/devtools/front_end/resources/DatabaseQueryView.js

@@ -57,7 +57,7 @@ WebInspector.DatabaseQueryView.Events = {

WebInspector.DatabaseQueryView.prototype = {

_messagesClicked: function()

{

- if (!this._prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)

+ if (!this._prompt.isCaretInsidePrompt() && this.element.window().getSelection().isCollapsed)

this._prompt.moveCaretToEndOfPrompt();

@@ -109,7 +109,7 @@ WebInspector.DatabaseQueryView.prototype = {

function moveBackIfOutside()

{

delete this._selectionTimeout;

- if (!this._prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)

+ if (!this._prompt.isCaretInsidePrompt() && this.element.window().getSelection().isCollapsed)

this._prompt.moveCaretToEndOfPrompt();

this._prompt.autoCompleteSoon();

}