Source/devtools/front_end/console/ConsoleView.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/console/ConsoleView.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/components/ObjectPropertiesSection.js ('k') | Source/devtools/front_end/elements/ElementsTreeOutline.js » ('j') | Source/devtools/front_end/profiler/CPUProfileFlameChart.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/console/ConsoleView.js

diff --git a/Source/devtools/front_end/console/ConsoleView.js b/Source/devtools/front_end/console/ConsoleView.js

index 908af5059261eaf8247a8edd19d09d2ae619d6c1..77f36382039bd321e8f5acbdd2806ad03ec2a5b2 100644

--- a/Source/devtools/front_end/console/ConsoleView.js

+++ b/Source/devtools/front_end/console/ConsoleView.js

@@ -711,7 +711,7 @@ WebInspector.ConsoleView.prototype = {

_messagesClicked: function(event)

{

- if (!this._prompt.isCaretInsidePrompt() && window.getSelection().isCollapsed)

+ if (!this._prompt.isCaretInsidePrompt() && event.target.window().getSelection().isCollapsed)

this._prompt.moveCaretToEndOfPrompt();

var groupMessage = event.target.enclosingNodeOrSelfWithClass("console-group-title");

if (!groupMessage)