Source/devtools/front_end/components/ObjectPropertiesSection.js - Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/components/ObjectPropertiesSection.js

Issue 727823002: [DevTools] Ban getSelection, requestAnimationFrame, cancelAnimationFrame global functions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/devtools/front_end/components/ObjectPropertiesSection.js

diff --git a/Source/devtools/front_end/components/ObjectPropertiesSection.js b/Source/devtools/front_end/components/ObjectPropertiesSection.js

index bb685230b3d4a34807d7fa0b6a84938f4a295963..9eef73f6a138749464674dec8481c391c71291f5 100644

--- a/Source/devtools/front_end/components/ObjectPropertiesSection.js

+++ b/Source/devtools/front_end/components/ObjectPropertiesSection.js

@@ -355,7 +355,7 @@ WebInspector.ObjectPropertyTreeElement.prototype = {

}

var proxyElement = this._prompt.attachAndStartEditing(elementToEdit, blurListener.bind(this));

- window.getSelection().setBaseAndExtent(elementToEdit, 0, elementToEdit, 1);

+ this.listItemElement.window().getSelection().setBaseAndExtent(elementToEdit, 0, elementToEdit, 1);

proxyElement.addEventListener("keydown", this._promptKeyDown.bind(this, context), false);

« no previous file with comments | « no previous file | Source/devtools/front_end/console/ConsoleView.js » ('j') | Source/devtools/front_end/profiler/CPUProfileFlameChart.js » ('J')