Issue 727693002: [turbofan] small cleanups to aid register allocator debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 727693002: [turbofan] small cleanups to aid register allocator debugging (Closed)

Created:
6 years, 1 month ago by dcarney

Modified:
6 years, 1 month ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] small cleanups to aid register allocator debugging BUG= R=bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/fb1795c4429eecc3af14f51417664aeba15fb0de

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -30 lines)			Patch
M	src/compiler/pipeline.cc	View	3 chunks	+4 lines, -7 lines	1 comment	Download
M	src/compiler/register-allocator.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/register-allocator.cc	View	4 chunks	+29 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Benedikt Meurer

LGTM https://codereview.chromium.org/727693002/diff/1/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/727693002/diff/1/src/compiler/pipeline.cc#newcode114 src/compiler/pipeline.cc:114: bool MayHaveUnverifiableGraph() { return outer_zone_ == nullptr; } ...

6 years, 1 month ago (2014-11-14 08:56:02 UTC) #2

dcarney

6 years, 1 month ago (2014-11-14 08:57:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb1795c4429eecc3af14f51417664aeba15fb0de (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages