Issue 727673002: [turbofan] Optimize remainder of integer division by unknown power of two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 727673002: [turbofan] Optimize remainder of integer division by unknown power of two. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer

Modified:
6 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Project:
v8

Visibility:
Public.

[turbofan] Optimize remainder of integer division by unknown power of two. Drive-by-Fix: minint % 0 was broken on ARM, but we didn't notice because there was no test covering that case... TEST=msjunit R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/45ff9d53c5c3fe4f6c9d58a7e3d200abc555a9d8

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -56 lines)			Patch
M	src/compiler/arm/instruction-selector-arm.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/compiler/machine-operator.h	View	1	2 chunks	+1 line, -5 lines	0 comments	Download
M	src/compiler/simplified-lowering.cc	View	1	2 chunks	+127 lines, -17 lines	0 comments	Download
M	test/mjsunit/asm/int32mod.js	View		1 chunk	+10 lines, -17 lines	0 comments	Download
A +	test/mjsunit/asm/int32mod-constant.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/asm/uint32mod.js	View		1 chunk	+10 lines, -14 lines	0 comments	Download
A +	test/mjsunit/asm/uint32mod-constant.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 4 (1 generated)

Benedikt Meurer

6 years, 1 month ago (2014-11-14 08:21:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
45ff9d53c5c3fe4f6c9d58a7e3d200abc555a9d8 (presubmit successful).