src/compiler/arm/instruction-selector-arm.cc - Issue 727673002: [turbofan] Optimize remainder of integer division by unknown power of two.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 727673002: [turbofan] Optimize remainder of integer division by unknown power of two. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix broken Int32Mod on ARM Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/arm/instruction-selector-arm.cc

diff --git a/src/compiler/arm/instruction-selector-arm.cc b/src/compiler/arm/instruction-selector-arm.cc

index 24168cc98e1225e71dbf14e19c94fb93f2ca322a..146aede53dc6e5ada6ff5bd5baa29e253e37995d 100644

--- a/src/compiler/arm/instruction-selector-arm.cc

+++ b/src/compiler/arm/instruction-selector-arm.cc

@@ -1255,9 +1255,7 @@ MachineOperatorBuilder::Flags

InstructionSelector::SupportedMachineOperatorFlags() {

MachineOperatorBuilder::Flags flags =

MachineOperatorBuilder::kInt32DivIsSafe |

- MachineOperatorBuilder::kInt32ModIsSafe |

- MachineOperatorBuilder::kUint32DivIsSafe |

- MachineOperatorBuilder::kUint32ModIsSafe;

+ MachineOperatorBuilder::kUint32DivIsSafe;

if (CpuFeatures::IsSupported(ARMv8)) {

flags |= MachineOperatorBuilder::kFloat64Floor |

« no previous file with comments | « no previous file | src/compiler/machine-operator.h » ('j') | no next file with comments »