Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Unified Diff: test/mjsunit/asm/uint32mod.js

Issue 727673002: [turbofan] Optimize remainder of integer division by unknown power of two. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix broken Int32Mod on ARM Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/asm/int32mod-constant.js ('k') | test/mjsunit/asm/uint32mod-constant.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/asm/uint32mod.js
diff --git a/test/mjsunit/asm/uint32mod.js b/test/mjsunit/asm/uint32mod.js
index 4ba94dad20393c4a4eebd01492a6a1f5bfc5d627..fa40507c7f746a27ea6f7ef020836023b64a87ee 100644
--- a/test/mjsunit/asm/uint32mod.js
+++ b/test/mjsunit/asm/uint32mod.js
@@ -6,24 +6,20 @@ var stdlib = {};
var foreign = {};
var heap = new ArrayBuffer(64 * 1024);
-function Uint32Mod(divisor) {
- var name = "mod_";
- name += divisor;
- var m = eval("function Module(stdlib, foreign, heap) {\n"
- + " \"use asm\";\n"
- + " function " + name + "(dividend) {\n"
- + " return ((dividend >>> 0) % " + divisor + ") >>> 0;\n"
- + " }\n"
- + " return { f: " + name + "}\n"
- + "}; Module");
- return m(stdlib, foreign, heap).f;
-}
+var mod = (function Module(stdlib, foreign, heap) {
+ "use asm";
+ function mod(dividend, divisor) {
+ dividend = dividend >>> 0;
+ divisor = divisor >>> 0;
+ return (dividend % divisor) >>> 0;
+ }
+ return { mod: mod };
+})(stdlib, foreign, heap).mod;
var divisors = [0, 1, 3, 4, 10, 42, 64, 100, 1024, 2147483647, 4294967295];
for (var i in divisors) {
var divisor = divisors[i];
- var mod = Uint32Mod(divisor);
for (var dividend = 0; dividend < 4294967296; dividend += 3999773) {
- assertEquals((dividend % divisor) >>> 0, mod(dividend));
+ assertEquals((dividend % divisor) >>> 0, mod(dividend, divisor));
}
}
« no previous file with comments | « test/mjsunit/asm/int32mod-constant.js ('k') | test/mjsunit/asm/uint32mod-constant.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698