Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 72753002: [Sheriff] Revert "Add support for keyed-call on arrays of fast elements" (Closed)

Created:
7 years, 1 month ago by Michael Achenbach
Modified:
7 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

[Sheriff] Revert "Add support for keyed-call on arrays of fast elements" This reverts commit r17746 for breaking layout tests. TBR=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17751

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -521 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +3 lines, -27 lines 0 comments Download
M src/ast.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/ast.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/code-stubs.h View 8 chunks +6 lines, -86 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/compiler.h View 2 chunks +0 lines, -7 lines 0 comments Download
M src/compiler.cc View 5 chunks +6 lines, -14 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +5 lines, -11 lines 0 comments Download
M src/frames.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/heap.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/hydrogen.h View 3 chunks +2 lines, -2 lines 0 comments Download
M src/hydrogen.cc View 2 chunks +6 lines, -18 lines 0 comments Download
M src/hydrogen-instructions.h View 2 chunks +2 lines, -23 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 2 chunks +3 lines, -27 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/ic.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ic.cc View 2 chunks +8 lines, -48 lines 0 comments Download
M src/isolate.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M src/lithium.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/type-info.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M src/typing.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +0 lines, -31 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
D test/mjsunit/keyed-array-call.js View 1 chunk +0 lines, -56 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Michael Achenbach
7 years, 1 month ago (2013-11-14 15:00:35 UTC) #1
Message was sent while issue was closed. 
Committed patchset #1 manually as r17751.

Powered by Google App Engine
This is Rietveld 408576698