src/typing.cc - Issue 72753002: [Sheriff] Revert "Add support for keyed-call on arrays of fast elements"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/typing.cc

Issue 72753002: [Sheriff] Revert "Add support for keyed-call on arrays of fast elements" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/typing.cc

diff --git a/src/typing.cc b/src/typing.cc

index 84f596859d76d48892d9cc4a976e8e6165439316..03c1ad16ef853a25a5b5a363ccf857dcd3ae55ae 100644

--- a/src/typing.cc

+++ b/src/typing.cc

@@ -450,7 +450,8 @@ void AstTyper::VisitCall(Call* expr) {

Expression* callee = expr->expression();

Property* prop = callee->AsProperty();

if (prop != NULL) {

- expr->RecordTypeFeedback(oracle(), CALL_AS_METHOD);

+ if (prop->key()->IsPropertyName())

+ expr->RecordTypeFeedback(oracle(), CALL_AS_METHOD);

} else {

expr->RecordTypeFeedback(oracle(), CALL_AS_FUNCTION);

}

« no previous file with comments | « src/type-info.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »