Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: src/typing.cc

Issue 72753002: [Sheriff] Revert "Add support for keyed-call on arrays of fast elements" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/type-info.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 432 matching lines...) Expand 10 before | Expand all | Expand 10 after
443 443
444 // We don't know anything about the result type. 444 // We don't know anything about the result type.
445 } 445 }
446 446
447 447
448 void AstTyper::VisitCall(Call* expr) { 448 void AstTyper::VisitCall(Call* expr) {
449 // Collect type feedback. 449 // Collect type feedback.
450 Expression* callee = expr->expression(); 450 Expression* callee = expr->expression();
451 Property* prop = callee->AsProperty(); 451 Property* prop = callee->AsProperty();
452 if (prop != NULL) { 452 if (prop != NULL) {
453 expr->RecordTypeFeedback(oracle(), CALL_AS_METHOD); 453 if (prop->key()->IsPropertyName())
454 expr->RecordTypeFeedback(oracle(), CALL_AS_METHOD);
454 } else { 455 } else {
455 expr->RecordTypeFeedback(oracle(), CALL_AS_FUNCTION); 456 expr->RecordTypeFeedback(oracle(), CALL_AS_FUNCTION);
456 } 457 }
457 458
458 RECURSE(Visit(expr->expression())); 459 RECURSE(Visit(expr->expression()));
459 ZoneList<Expression*>* args = expr->arguments(); 460 ZoneList<Expression*>* args = expr->arguments();
460 for (int i = 0; i < args->length(); ++i) { 461 for (int i = 0; i < args->length(); ++i) {
461 Expression* arg = args->at(i); 462 Expression* arg = args->at(i);
462 RECURSE(Visit(arg)); 463 RECURSE(Visit(arg));
463 } 464 }
(...skipping 245 matching lines...) Expand 10 before | Expand all | Expand 10 after
709 void AstTyper::VisitModuleUrl(ModuleUrl* module) { 710 void AstTyper::VisitModuleUrl(ModuleUrl* module) {
710 } 711 }
711 712
712 713
713 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) { 714 void AstTyper::VisitModuleStatement(ModuleStatement* stmt) {
714 RECURSE(Visit(stmt->body())); 715 RECURSE(Visit(stmt->body()));
715 } 716 }
716 717
717 718
718 } } // namespace v8::internal 719 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/type-info.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698