Issue 726793002: IDL: Update type error message for invalid union values

Issue 726793002: IDL: Update type error message for invalid union values (Closed)

Created:
6 years, 1 month ago by bashi

Modified:
6 years, 1 month ago

Reviewers:
haraken

CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Project:
blink

Visibility:
Public.

More Reviews

Description

IDL: Update type error message for invalid union values The error message should explain what types are expected. BUG=240176 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185340

Patch Set 2 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -58 lines)			Patch
M	LayoutTests/canvas/philip/tests/2d.pattern.image.string-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/canvas/philip/tests/2d.pattern.image.undefined-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/canvas/canvas-pattern-behaviour-expected.txt	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/canvas/drawImage-with-broken-image-expected.txt	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/HTMLSelectElement/select-selectedIndex-expected.txt	View		1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/idl-union-type-unittest-expected.txt	View		1 chunk	+6 lines, -6 lines	0 comments	Download
M	LayoutTests/fast/dom/incompatible-operations-expected.txt	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	LayoutTests/fast/forms/select/select-add-expected.txt	View		2 chunks	+12 lines, -12 lines	0 comments	Download
M	LayoutTests/fast/js/select-options-add-expected.txt	View		2 chunks	+18 lines, -18 lines	0 comments	Download
M	Source/bindings/scripts/v8_union.py	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/bindings/templates/union.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/core/UnionTypesCore.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

haraken

LGTM https://codereview.chromium.org/726793002/diff/1/Source/bindings/scripts/v8_union.py File Source/bindings/scripts/v8_union.py (right): https://codereview.chromium.org/726793002/diff/1/Source/bindings/scripts/v8_union.py#newcode112 Source/bindings/scripts/v8_union.py:112: 'idl_type': str(union_type), idl_type => type_string ? (The IDL ...

6 years, 1 month ago (2014-11-14 00:44:31 UTC) #3

bashi

Thank you for review! https://codereview.chromium.org/726793002/diff/1/Source/bindings/scripts/v8_union.py File Source/bindings/scripts/v8_union.py (right): https://codereview.chromium.org/726793002/diff/1/Source/bindings/scripts/v8_union.py#newcode112 Source/bindings/scripts/v8_union.py:112: 'idl_type': str(union_type), On 2014/11/14 00:44:30, ...

6 years, 1 month ago (2014-11-14 00:51:39 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726793002/20001

6 years, 1 month ago (2014-11-14 00:52:54 UTC) #6

commit-bot: I haz the power

6 years, 1 month ago (2014-11-14 02:06:43 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as 185340

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages