Source/bindings/templates/union.cpp - Issue 726793002: IDL: Update type error message for invalid union values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/union.cpp

Issue 726793002: IDL: Update type error message for invalid union values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/union.cpp

diff --git a/Source/bindings/templates/union.cpp b/Source/bindings/templates/union.cpp

index 3c9fbd493870146dd4c5802f219655c46033ed48..bd48a281609ab9fa32b83bb3e949b2d7bf583816 100644

--- a/Source/bindings/templates/union.cpp

+++ b/Source/bindings/templates/union.cpp

@@ -133,7 +133,7 @@ void V8{{container.cpp_class}}::toImpl(v8::Isolate* isolate, v8::Handle<v8::Valu

{% else %}

{# 19. TypeError #}

- exceptionState.throwTypeError("Not a valid union member.");

+ exceptionState.throwTypeError("The provided value is not of type '{{container.type_string}}'");

{% endif %}

}

« no previous file with comments | « Source/bindings/scripts/v8_union.py ('k') | Source/bindings/tests/results/core/UnionTypesCore.cpp » ('j') | no next file with comments »