Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: LayoutTests/fast/forms/select/select-add-expected.txt

Issue 726793002: IDL: Update type error message for invalid union values (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/forms/select/select-add-expected.txt
diff --git a/LayoutTests/fast/forms/select/select-add-expected.txt b/LayoutTests/fast/forms/select/select-add-expected.txt
index 8dca86daeef47177c98fbde0afe1e30c674fbf64..4074af6c39aab0dd66d6247b43aeb01e7b87b42c 100644
--- a/LayoutTests/fast/forms/select/select-add-expected.txt
+++ b/LayoutTests/fast/forms/select/select-add-expected.txt
@@ -18,12 +18,12 @@ PASS addOption(Infinity) is "X,0,1,2"
PASS addOption(-Infinity) is "X,0,1,2"
PASS addOption("foo") is "X,0,1,2"
PASS select.add() threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': 1 argument required, but only 0 present..
-PASS select.add("foo") threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add("foo", 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(undefined) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(undefined, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(null) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(null, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
+PASS select.add("foo") threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add("foo", 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(undefined) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(undefined, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(null) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(null, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
PASS getSelectOptions() is "0,X,Y,1,2"
Test select multiple
PASS addOption(0) is "X,0,1,2"
@@ -40,12 +40,12 @@ PASS addOption(Infinity) is "X,0,1,2"
PASS addOption(-Infinity) is "X,0,1,2"
PASS addOption("foo") is "X,0,1,2"
PASS select.add() threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': 1 argument required, but only 0 present..
-PASS select.add("foo") threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add("foo", 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(undefined) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(undefined, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(null) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
-PASS select.add(null, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': Not a valid union member..
+PASS select.add("foo") threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add("foo", 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(undefined) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(undefined, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(null) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
+PASS select.add(null, 0) threw exception TypeError: Failed to execute 'add' on 'HTMLSelectElement': The provided value is not of type '(HTMLOptionElement or HTMLOptGroupElement)'.
PASS getSelectOptions() is "0,X,Y,1,2"
PASS successfullyParsed is true
« no previous file with comments | « LayoutTests/fast/dom/incompatible-operations-expected.txt ('k') | LayoutTests/fast/js/select-options-add-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698