Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 726343002: OOP PDF: Add whether a resource is embedded to StreamInfo. (Closed)

Created:
6 years, 1 month ago by Sam McNally
Modified:
6 years, 1 month ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@embedded-pdfs
Project:
chromium
Visibility:
Public.

Description

OOP PDF: Add whether a resource is embedded to StreamInfo. Previously, the out-of-process PDF extension managed page zoom for all PDFs. This is not correct for embedded PDFs, which should not affect or be affected by page zoom. This CL makes that information available to the extension and uses it to decide not manage page zoom for embedded PDFs. BUG=433713 TEST=Run with --out-of-process-pdf. Open a page embedding a PDF. Zooming should affect the page, including the size of the PDF viewport, but not the zoom level of the PDF. Committed: https://crrev.com/3ae8287447b46a6bceeec089cebb52e79633f916 Cr-Commit-Position: refs/heads/master@{#305394}

Patch Set 1 : #

Patch Set 2 : !streamDetails.embedded => 'full-frame' #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -15 lines) Patch
M chrome/browser/extensions/api/streams_private/streams_private_api.h View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/resources/pdf/main.js View 1 chunk +12 lines, -2 lines 0 comments Download
M chrome/browser/resources/pdf/pdf.js View 1 4 chunks +14 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/streams_private.idl View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
Sam McNally
6 years, 1 month ago (2014-11-17 03:01:48 UTC) #4
raymes
lgtm https://codereview.chromium.org/726343002/diff/60001/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (right): https://codereview.chromium.org/726343002/diff/60001/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode641 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:641: info->GetResourceType() != content::RESOURCE_TYPE_MAIN_FRAME)); nit: maybe just split this ...
6 years, 1 month ago (2014-11-17 04:09:38 UTC) #5
Sam McNally
+zork for chrome/browser/extensions/api/streams_private/ https://codereview.chromium.org/726343002/diff/60001/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc File chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc (right): https://codereview.chromium.org/726343002/diff/60001/chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc#newcode641 chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc:641: info->GetResourceType() != content::RESOURCE_TYPE_MAIN_FRAME)); On 2014/11/17 04:09:38, ...
6 years, 1 month ago (2014-11-17 04:31:29 UTC) #7
Sam McNally
zork: ping
6 years, 1 month ago (2014-11-19 04:46:52 UTC) #8
Zachary Kuznia
lgtm
6 years, 1 month ago (2014-11-19 21:43:14 UTC) #9
Sam McNally
+benwells for chrome/common/extensions/api/streams_private.idl +jam for chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc
6 years, 1 month ago (2014-11-19 23:45:18 UTC) #11
jam
lgtm
6 years, 1 month ago (2014-11-20 21:08:31 UTC) #12
benwells
lgtm
6 years, 1 month ago (2014-11-23 23:55:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/726343002/80001
6 years, 1 month ago (2014-11-23 23:56:05 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:80001)
6 years, 1 month ago (2014-11-24 01:45:01 UTC) #16
commit-bot: I haz the power
6 years, 1 month ago (2014-11-24 01:46:55 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3ae8287447b46a6bceeec089cebb52e79633f916
Cr-Commit-Position: refs/heads/master@{#305394}

Powered by Google App Engine
This is Rietveld 408576698