chrome/browser/resources/pdf/main.js - Issue 726343002: OOP PDF: Add whether a resource is embedded to StreamInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/main.js

Issue 726343002: OOP PDF: Add whether a resource is embedded to StreamInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@embedded-pdfs

Patch Set: address comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/main.js

diff --git a/chrome/browser/resources/pdf/main.js b/chrome/browser/resources/pdf/main.js

index 92171567eab52358dbedf3a1e90e91b77991e7d0..34c9196a0f62753b1281fdd63d4793c905757779 100644

--- a/chrome/browser/resources/pdf/main.js

+++ b/chrome/browser/resources/pdf/main.js

@@ -46,7 +46,17 @@ var viewer;

var streamDetails = {

streamUrl: url,

originalUrl: url,

- responseHeaders: ''

+ responseHeaders: '',

+ embedded: window.parent != window,

+ tabId: -1

};

- viewer = new PDFViewer(streamDetails);

+ if (!chrome.tabs) {

+ viewer = new PDFViewer(streamDetails);

+ return;

+ }

+ chrome.tabs.getCurrent(function(tab) {

+ if (tab && tab.id != undefined)

+ streamDetails.tabId = tab.id;

+ viewer = new PDFViewer(streamDetails);

+ });

})();

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | chrome/browser/resources/pdf/pdf.js » ('j') | no next file with comments »