chrome/browser/extensions/api/streams_private/streams_private_api.cc - Issue 726343002: OOP PDF: Add whether a resource is embedded to StreamInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_api.cc

Issue 726343002: OOP PDF: Add whether a resource is embedded to StreamInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@embedded-pdfs

Patch Set: address comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/streams_private/streams_private_api.h ('k') | chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/streams_private/streams_private_api.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

index a47b5443d184f367a973b09124bc3289fa452f18..9ee09418d82a7deccf65afbd6da33eee780fe91d 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_api.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

@@ -63,13 +63,15 @@ void StreamsPrivateAPI::ExecuteMimeTypeHandler(

content::WebContents* web_contents,

scoped_ptr<content::StreamInfo> stream,

const std::string& view_id,

- int64 expected_content_size) {

+ int64 expected_content_size,

+ bool embedded) {

// Create the event's arguments value.

streams_private::StreamInfo info;

info.mime_type = stream->mime_type;

info.original_url = stream->original_url.spec();

info.stream_url = stream->handle->GetURL().spec();

info.tab_id = ExtensionTabUtil::GetTabId(web_contents);

+ info.embedded = embedded;

if (!view_id.empty()) {

info.view_id.reset(new std::string(view_id));