Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 726133002: Use root-relative V8 includes (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
abarth-chromium
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -130 lines) Patch
M sky/engine/bindings/core/v8/ArrayValue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/BindingSecurity.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/CustomElementBinding.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/CustomElementConstructorBuilder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/CustomElementWrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/DOMDataStore.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/DOMWrapperMap.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/DOMWrapperWorld.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/Dictionary.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ExceptionState.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ExceptionStatePlaceholder.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/RetainedDOMInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/RetainedObjectInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScheduledAction.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScopedPersistent.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptCallStackFactory.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptCallStackFactory.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptController.h View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptFunctionCall.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptGCEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptHeapSnapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptHeapSnapshot.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPreprocessor.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptProfiler.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromise.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromise.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromisePropertyBase.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptState.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptString.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/ScriptWrappable.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/SharedPersistent.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8AbstractEventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8Binding.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8DOMConfiguration.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8DOMWrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8ErrorHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8EventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8EventListenerList.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8GCController.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8GCForContextDispose.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8HiddenValue.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8Initializer.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8Initializer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8MutationCallback.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8ObjectConstructor.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8PerContextData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8PerIsolateData.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8PersistentValueMap.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/bindings/core/v8/V8PersistentValueVector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8RecursionScope.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8ScriptRunner.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8StringResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/bindings/core/v8/V8ThrowException.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/V8ValueCache.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/WindowProxy.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M sky/engine/bindings/core/v8/WrapperTypeInfo.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8ArrayBufferCustom.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8ArrayBufferViewCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/bindings/core/v8/custom/V8TypedArrayCustom.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/build/scripts/templates/ElementWrapperFactory.h.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/AnimationTest.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/core/animation/AnimationTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/EffectInputTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/core/animation/TimingInputTest.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Microtask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/StaticNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/events/ErrorEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLCanvasElement.cpp View 1 chunk +8 lines, -7 lines 0 comments Download
M sky/engine/core/inspector/JavaScriptCallFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/inspector/ScriptArguments.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/inspector/ScriptProfile.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/inspector/ScriptProfile.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/loader/FrameLoaderClient.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/DEPS View 1 chunk +5 lines, -4 lines 0 comments Download
M sky/engine/platform/graphics/Pattern.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/public/platform/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/public/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/public/web/WebFrameClient.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M sky/engine/web/FrameLoaderClientImpl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/web/Sky.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M sky/engine/web/WebDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/web/WebLeakDetector.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eseidel
6 years, 1 month ago (2014-11-15 00:01:49 UTC) #1
eseidel
6 years, 1 month ago (2014-11-15 00:02:26 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4acca86dc17495101eb9273680d7fa303399b3ee.

Powered by Google App Engine
This is Rietveld 408576698