Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 725243004: Disable LCD text explicitly in SkPictureImageFilter::onFilterImage() (Closed)

Created:
6 years, 1 month ago by f(malita)
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Disable LCD text explicitly in SkPictureImageFilter::onFilterImage() As an intermediate fix for https://code.google.com/p/skia/issues/detail?id=3142, we can use a non-public SkCanvas constructor and force-disable LCD text. BUG=skia:3142 R=reed@google.com,senorblanco@google.com Committed: https://skia.googlesource.com/skia/+/2d97bc139a7de5813468bd3dbfd0037351ae5606

Patch Set 1 #

Patch Set 2 : surface props plumbing #

Total comments: 2

Patch Set 3 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -19 lines) Patch
M include/core/SkCanvas.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkImageFilter.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/core/SkDeviceImageFilterProxy.h View 1 2 chunks +15 lines, -2 lines 0 comments Download
M src/effects/SkPictureImageFilter.cpp View 1 2 chunks +5 lines, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 4 chunks +13 lines, -10 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
f(malita)
6 years, 1 month ago (2014-11-19 20:53:01 UTC) #1
Stephen White
LGTM, but will leave for Mike.
6 years, 1 month ago (2014-11-19 21:15:00 UTC) #3
f(malita)
After talking with Mike, PS#2 is an attempt to plumb actual SkSurfaceProps (and rely on ...
6 years, 1 month ago (2014-11-19 23:44:13 UTC) #4
reed1
lgtm https://codereview.chromium.org/725243004/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/725243004/diff/20001/src/gpu/SkGpuDevice.cpp#newcode1355 src/gpu/SkGpuDevice.cpp:1355: SkASSERT(filter); lets add a comment/bug to somehow get ...
6 years, 1 month ago (2014-11-20 17:21:45 UTC) #5
f(malita)
https://codereview.chromium.org/725243004/diff/20001/src/gpu/SkGpuDevice.cpp File src/gpu/SkGpuDevice.cpp (right): https://codereview.chromium.org/725243004/diff/20001/src/gpu/SkGpuDevice.cpp#newcode1355 src/gpu/SkGpuDevice.cpp:1355: SkASSERT(filter); On 2014/11/20 17:21:44, reed1 wrote: > lets add ...
6 years, 1 month ago (2014-11-20 18:35:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725243004/40001
6 years, 1 month ago (2014-11-20 18:36:08 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 18:45:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2d97bc139a7de5813468bd3dbfd0037351ae5606

Powered by Google App Engine
This is Rietveld 408576698