Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 725023002: Remove Dictionary::getWithUndefinedOrNullCheck() (Closed)

Created:
6 years, 1 month ago by bashi
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org, jsbell+idb_chromium.org, arv+blink, cmumford, dgrogan
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove Dictionary::getWithUndefinedOrNullCheck() We have three specialized getWithUndefinedOrNullCheck(), but we don't need them, as DictionaryHelper::getWithUndefinedOrNullCheck() template does the job. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185344

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M Source/bindings/core/v8/Dictionary.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/Dictionary.cpp View 1 chunk +0 lines, -31 lines 0 comments Download
M Source/modules/indexeddb/IDBDatabase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/indexeddb/IDBDatabase.idl View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL? https://codereview.chromium.org/725023002/diff/1/Source/modules/indexeddb/IDBDatabase.idl File Source/modules/indexeddb/IDBDatabase.idl (right): https://codereview.chromium.org/725023002/diff/1/Source/modules/indexeddb/IDBDatabase.idl#newcode43 Source/modules/indexeddb/IDBDatabase.idl:43: // FIXME: |options| should be an IDL dictionary ...
6 years, 1 month ago (2014-11-14 02:19:53 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-11-14 02:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/725023002/1
6 years, 1 month ago (2014-11-14 03:02:59 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-14 03:05:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185344

Powered by Google App Engine
This is Rietveld 408576698