Source/modules/indexeddb/IDBDatabase.cpp - Issue 725023002: Remove Dictionary::getWithUndefinedOrNullCheck()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBDatabase.cpp

Issue 725023002: Remove Dictionary::getWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/indexeddb/IDBDatabase.cpp

diff --git a/Source/modules/indexeddb/IDBDatabase.cpp b/Source/modules/indexeddb/IDBDatabase.cpp

index a02f9c5e30906804a27e5be2a822e67cb98cce1a..3ed36949631ea01b42817526131c88f7fe7bfd29 100644

--- a/Source/modules/indexeddb/IDBDatabase.cpp

+++ b/Source/modules/indexeddb/IDBDatabase.cpp

@@ -204,7 +204,7 @@ IDBObjectStore* IDBDatabase::createObjectStore(const String& name, const Diction

Vector<String> keyPathArray;

if (DictionaryHelper::get(options, "keyPath", keyPathArray))

keyPath = IDBKeyPath(keyPathArray);

- else if (options.getWithUndefinedOrNullCheck("keyPath", keyPathString))

+ else if (DictionaryHelper::getWithUndefinedOrNullCheck(options, "keyPath", keyPathString))

keyPath = IDBKeyPath(keyPathString);

DictionaryHelper::get(options, "autoIncrement", autoIncrement);