Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: Source/bindings/core/v8/Dictionary.cpp

Issue 725023002: Remove Dictionary::getWithUndefinedOrNullCheck() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/Dictionary.cpp
diff --git a/Source/bindings/core/v8/Dictionary.cpp b/Source/bindings/core/v8/Dictionary.cpp
index 16dcdfd9b6f085bddd8f1de3b2ad75eaf2fea673..2e43109fbbb42298753c9dd1523e5188da78e538 100644
--- a/Source/bindings/core/v8/Dictionary.cpp
+++ b/Source/bindings/core/v8/Dictionary.cpp
@@ -125,37 +125,6 @@ bool Dictionary::get(const String& key, v8::Local<v8::Value>& value) const
return getKey(key, value);
}
-bool Dictionary::getWithUndefinedOrNullCheck(const String& key, String& value) const
-{
- v8::Local<v8::Value> v8Value;
- if (!getKey(key, v8Value) || blink::isUndefinedOrNull(v8Value))
- return false;
-
- TOSTRING_DEFAULT(V8StringResource<>, stringValue, v8Value, false);
- value = stringValue;
- return true;
-}
-
-bool Dictionary::getWithUndefinedOrNullCheck(const String& key, RefPtrWillBeMember<Element>& value) const
-{
- v8::Local<v8::Value> v8Value;
- if (!getKey(key, v8Value) || blink::isUndefinedOrNull(v8Value))
- return false;
-
- value = V8Element::toImplWithTypeCheck(m_isolate, v8Value);
- return true;
-}
-
-bool Dictionary::getWithUndefinedOrNullCheck(const String& key, RefPtrWillBeMember<Path2D>& value) const
-{
- v8::Local<v8::Value> v8Value;
- if (!getKey(key, v8Value) || blink::isUndefinedOrNull(v8Value))
- return false;
-
- value = V8Path2D::toImplWithTypeCheck(m_isolate, v8Value);
- return true;
-}
-
bool Dictionary::get(const String& key, Dictionary& value) const
{
v8::Local<v8::Value> v8Value;

Powered by Google App Engine
This is Rietveld 408576698