Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(55)

Issue 7232023: Added last_modified field to TemplateURL and database. Updated unit tests, including refactoring ... (Closed)

Created:
7 years, 9 months ago by SteveT
Modified:
7 years, 8 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, sjl, ddorwin+watch_chromium.org, fischman+watch_chromium.org, tfarina, PaweĊ‚ Hajdan Jr., acolwell GONE FROM CHROMIUM, annacc, ajwong+watch_chromium.org, vrk (LEFT CHROMIUM), dhollowa, scherkus (not reviewing)
Visibility:
Public.

Description

Added last_modified field to TemplateURL and database. Updated unit tests, including refactoring MockTimeProvider out of media/. BUG=None TEST=No visible changes. Ensure that changed unittests all pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=90764

Patch Set 1 : Initial upload. #

Total comments: 14

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -89 lines) Patch
M base/base.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
A base/test/mock_time_provider.h View 1 1 chunk +66 lines, -0 lines 0 comments Download
A base/test/mock_time_provider.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/importer/profile_import_process_messages.h View 4 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_prepopulate_data.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.h View 1 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 25 chunks +55 lines, -21 lines 0 comments Download
M chrome/browser/webdata/keyword_table.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/webdata/keyword_table.cc View 1 8 chunks +16 lines, -6 lines 0 comments Download
M chrome/browser/webdata/keyword_table_unittest.cc View 1 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/webdata/web_database.cc View 2 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/webdata/web_database_migration_unittest.cc View 1 9 chunks +52 lines, -12 lines 0 comments Download
A chrome/test/data/web_database/version_37.sql View 1 chunk +26 lines, -0 lines 0 comments Download
M media/base/clock_unittest.cc View 1 15 chunks +19 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
SteveT
Hey guys, Andrew - Have a look at the factored out mock_time_provider from Media, which ...
7 years, 9 months ago (2011-06-22 21:48:35 UTC) #1
scherkus (not reviewing)
+brettw for base OWNERS http://codereview.chromium.org/7232023/diff/2003/base/mock_time_provider.h File base/mock_time_provider.h (right): http://codereview.chromium.org/7232023/diff/2003/base/mock_time_provider.h#newcode7 base/mock_time_provider.h:7: #include "base/time.h" needs a header ...
7 years, 9 months ago (2011-06-22 22:12:51 UTC) #2
sky
LGTM with the following changes http://codereview.chromium.org/7232023/diff/2003/chrome/browser/search_engines/template_url_service.cc File chrome/browser/search_engines/template_url_service.cc (right): http://codereview.chromium.org/7232023/diff/2003/chrome/browser/search_engines/template_url_service.cc#newcode640 chrome/browser/search_engines/template_url_service.cc:640: void TemplateURLService::InstallTimeProvider(TimeProvider* time_provider) { ...
7 years, 9 months ago (2011-06-22 22:38:06 UTC) #3
brettw
http://codereview.chromium.org/7232023/diff/2003/base/mock_time_provider.h File base/mock_time_provider.h (right): http://codereview.chromium.org/7232023/diff/2003/base/mock_time_provider.h#newcode11 base/mock_time_provider.h:11: class MockTimeProvider { I don't understand how this works ...
7 years, 9 months ago (2011-06-22 22:52:41 UTC) #4
SteveT
Made changes as suggested. I've added the missing description to mock_time_provider and moved the files ...
7 years, 9 months ago (2011-06-23 21:15:55 UTC) #5
brettw
LGTM on base, since this is only in the test project, I think it's fine ...
7 years, 9 months ago (2011-06-23 22:23:53 UTC) #6
brettw
LGTM on base, since this is only in the test project, I think it's fine ...
7 years, 9 months ago (2011-06-23 22:23:54 UTC) #7
scherkus (not reviewing)
7 years, 8 months ago (2011-06-27 18:58:11 UTC) #8
LGTM on media etc

Powered by Google App Engine
This is Rietveld 408576698